[RF] Consistent treatment of empty datasets with new CPU backend #14817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
This was referenced Feb 25, 2024
As we discovered in a CMSSW ROOT `master` sync PR, the new RooFit CPU backend treats empty datasets differently from the legacy NLL evaluation backend: cms-sw/cmsdist#9025 This commit is fixing this, in particular removing the assumption that datasets used for fits with the new CPU backend are never empty. A unit test that validates the behavior for empty data objects is also added.
Also, write out "constructor" instead of using the slang abbriviation "ctor".
guitargeek
force-pushed
the
roofit_empty_data
branch
from
42db0cd to
e54aecf
Compare
|
Starting build on |
|
It was validated locally that the test now also passes with the CUDA backend. |
Test Results 12 files 12 suites 2d 11h 0m 31s ⏱️ For more details on these failures, see this check. Results for commit e54aecf. |
lmoneta
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discovered in a CMSSW ROOT
mastersync PR, the new RooFit CPUbackend treats empty datasets differently from the legacy NLL evaluation
backend:
cms-sw/cmsdist#9025
This commit is fixing this, in particular removing the assumption that
datasets used for fits with the new CPU backend are never empty.
A unit test that validates the behavior for empty data objects is also
added.
I set the priority to "high" because this is a blocker for CMSSW to use ROOT master.