Exclude directories from coverage #13596

AniqJaved · 2023-09-04T13:41:40Z

This Pull request:

Changes or fixes:

Checklist:

tested changes locally
updated the docs (if necessary)

This PR fixes #

phsft-bot · 2023-09-04T13:41:48Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

github-actions · 2023-09-04T13:42:26Z

Test Results

0 tests 0 ✔️ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit de56c64.

♻️ This comment has been updated with latest results.

phsft-bot · 2023-09-04T13:42:52Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
See console output.

Axel-Naumann · 2023-09-04T13:46:29Z

.github/workflows/test-coverage.yml

-  #  paths-ignore:
-  #    - 'doc/**'
-  #    - 'documentation/**'
+  pull_request:


I suppose we want to remove this again from this PR before we merge it?

Axel-Naumann · 2023-09-04T13:46:53Z

.github/workflows/test-coverage.yml

        env:
-          OVERRIDE: "coverage=On"
-          FILE: .github/workflows/root-ci-config/buildconfig/fedora38.txt
+          OVERRIDES: "coverage=On testing=On roottest=On"


This should already be on without this change I hope?!

Axel-Naumann · 2023-09-04T13:48:00Z

.github/workflows/test-coverage.yml

@@ -143,4 +156,4 @@ jobs:
          files: /github/home/ROOT-CI/build/cobertura-cov.xml
          flags: unittests
          name: codecov-umbrella
-          verbose: true
+          verbose: true


Can you re-add the final newline, please?

Axel-Naumann · 2023-09-04T13:48:56Z

This PR needs to have its history rewritten - possible simply squashing all commits.

phsft-bot · 2023-09-04T14:22:32Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T14:22:26.760Z] stderr: error: Failed to merge in the changes.
[2023-09-04T14:22:31.959Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T14:46:34Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-09-04T14:46:33.358Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T14:52:12Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-09-04T14:52:33Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T14:52:32.117Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T15:02:49Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T15:02:42.413Z] stderr: error: Failed to merge in the changes.
[2023-09-04T15:02:47.670Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T15:28:34Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-09-04T15:28:33.863Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T16:41:33Z

Build failed on mac11/noimt.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T16:41:32.354Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T17:45:52Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T17:45:51.156Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-04T19:55:10Z

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-04T19:55:09.420Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-05T09:27:23Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-09-05T09:27:28Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
See console output.

phsft-bot · 2023-09-05T09:30:34Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-09-05T09:30:29.289Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-05T09:46:59Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-09-05T09:47:59Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
See console output.

Axel-Naumann · 2023-09-05T17:32:30Z

.github/workflows/test-coverage.yml

@@ -144,3 +138,4 @@ jobs:
          flags: unittests
          name: codecov-umbrella
          verbose: true
+


There is a missing newline here. Or maybe there's a newline but it's followed by spaces: please remove the spaces then.

The GitHub view of this PR must not say "no newline at the end of file"

Axel-Naumann · 2023-09-05T17:33:58Z

.github/workflows/test-coverage.yml

@@ -123,6 +115,8 @@ jobs:
                    --repository     ${{ github.server_url }}/${{ github.repository }}
              "

+
+


That change doesn't seem to be needed?

.github/workflows/test-coverage.yml

Axel-Naumann · 2023-09-05T17:35:57Z

.github/workflows/test-coverage.yml

-  #    - 'master'
-  #  paths-ignore:
-  #    - 'doc/**'
-  #    - 'documentation/**'


I think it'd be nice to keep this comment block as a reminder.

Axel-Naumann · 2023-09-05T17:36:12Z

.github/workflows/root-ci-config/build_root.py

    """)

    if result != 0:
        die(result, "Failed to create test coverage")

-


Stray change?

phsft-bot · 2023-09-05T20:26:12Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-09-05T20:27:59Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
See console output.

phsft-bot · 2023-09-05T20:35:16Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-09-05T20:35:20Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
See console output.

phsft-bot · 2023-09-06T08:56:23Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

Axel-Naumann

Excellent!

phsft-bot · 2023-09-06T09:25:01Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-09-06T09:25:01.006Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-06T09:26:51Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch

phsft-bot · 2023-09-06T09:43:33Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-06T09:43:32.047Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-06T09:59:01Z

Build failed on mac11/noimt.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-06T09:59:00.549Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-06T10:07:58Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-06T10:07:57.548Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

phsft-bot · 2023-09-06T11:48:21Z

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-09-06T11:48:20.682Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1147 (message):

AniqJaved requested a review from Axel-Naumann as a code owner September 4, 2023 13:41

Axel-Naumann requested changes Sep 4, 2023

View reviewed changes

Axel-Naumann self-assigned this Sep 4, 2023

Exclude directories from coverage

95bcd9e

AniqJaved force-pushed the codecov branch from 98c0fc7 to 95bcd9e Compare September 5, 2023 09:46

Axel-Naumann requested changes Sep 5, 2023

View reviewed changes

Make proposed changes to PR

f676a04

Make proposed changes to PR

de56c64

Make proposed changes to PR

6bd3909

Axel-Naumann approved these changes Sep 6, 2023

View reviewed changes

Axel-Naumann merged commit b2760a4 into root-project:master Sep 6, 2023

maksgraczyk pushed a commit to maksgraczyk/root that referenced this pull request Jan 12, 2024

Exclude some directories from coverage (root-project#13596)

42e5108

		@@ -123,6 +115,8 @@ jobs:
		--repository ${{ github.server_url }}/${{ github.repository }}
		"

Exclude directories from coverage #13596

Exclude directories from coverage #13596

Conversation

AniqJaved commented Sep 4, 2023

This Pull request:

Changes or fixes:

Checklist:

phsft-bot commented Sep 4, 2023

github-actions bot commented Sep 4, 2023 • edited Loading

Test Results

phsft-bot commented Sep 4, 2023

Axel-Naumann Sep 4, 2023

Choose a reason for hiding this comment

Axel-Naumann Sep 4, 2023

Choose a reason for hiding this comment

Axel-Naumann Sep 4, 2023

Choose a reason for hiding this comment

Axel-Naumann commented Sep 4, 2023

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 4, 2023

Errors:

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

Errors:

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

Axel-Naumann Sep 5, 2023

Choose a reason for hiding this comment

Axel-Naumann Sep 5, 2023

Choose a reason for hiding this comment

Axel-Naumann Sep 5, 2023

Choose a reason for hiding this comment

Axel-Naumann Sep 5, 2023

Choose a reason for hiding this comment

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 5, 2023

phsft-bot commented Sep 6, 2023

Axel-Naumann left a comment

Choose a reason for hiding this comment

phsft-bot commented Sep 6, 2023

Errors:

phsft-bot commented Sep 6, 2023

Failing tests:

phsft-bot commented Sep 6, 2023

Errors:

phsft-bot commented Sep 6, 2023

Errors:

phsft-bot commented Sep 6, 2023

Errors:

phsft-bot commented Sep 6, 2023

Errors:

github-actions bot commented Sep 4, 2023 •

edited

Loading