-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DF] Remove RResultPtr::Release (an unreleased feature)
The current implementation is broken (fObjPtr.release() deletes the object thet we then return by pointer) and in general it is extremely awkward to convince a std::shared_ptr to release ownership (and for good reason, it only makes sense if you can be absolutely sure that there is only one shared_ptr alive that owns that object). Instead of using RResultPtr::Release, we recommend moving the result out of the RResultPtr. This effectively reverts commit 03fd58e.
- Loading branch information
Showing
2 changed files
with
2 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters