Skip to content

Commit

Permalink
Update warning flag for bidi characters (#9532)
Browse files Browse the repository at this point in the history
-Wbidirectional= was RedHat's initial proposal that they also shipped
in gcc-8.5.0-4.el8 for CentOS 8. During review, the name was changed
to -Wbidi-chars= which will appear in GCC 12 and was backported to the
next gcc-8.5.0-5.el8. See the mailing list thread at
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/thread.html#583031
for details.
  • Loading branch information
hahnjo authored Jan 15, 2022
1 parent 4112fb9 commit 628e283
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions graf2d/mathtext/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ ROOT_LINKER_LIBRARY(mathtext
NOINSTALL
)

check_cxx_compiler_flag(-Wbidirectional=none GCC_HAS_BIDIRECTIONAL_FLAG)
if(GCC_HAS_BIDIRECTIONAL_FLAG)
set_source_files_properties(src/fontembed.cxx COMPILE_FLAGS "-Wbidirectional=none")
check_cxx_compiler_flag(-Wbidi-chars=none GCC_HAS_BIDI_CHARS_FLAG)
if(GCC_HAS_BIDI_CHARS_FLAG)
set_source_files_properties(src/fontembed.cxx COMPILE_FLAGS "-Wbidi-chars=none")
endif()
set_property(TARGET mathtext PROPERTY POSITION_INDEPENDENT_CODE ON)
6 changes: 3 additions & 3 deletions graf2d/postscript/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ROOT_STANDARD_LIBRARY_PACKAGE(Postscript
Graf
)

check_cxx_compiler_flag(-Wbidirectional=none GCC_HAS_BIDIRECTIONAL_FLAG)
if(GCC_HAS_BIDIRECTIONAL_FLAG)
set_source_files_properties(src/TPostScript.cxx COMPILE_FLAGS "-Wbidirectional=none")
check_cxx_compiler_flag(-Wbidi-chars=none GCC_HAS_BIDI_CHARS_FLAG)
if(GCC_HAS_BIDI_CHARS_FLAG)
set_source_files_properties(src/TPostScript.cxx COMPILE_FLAGS "-Wbidi-chars=none")
endif()

0 comments on commit 628e283

Please sign in to comment.