Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fix none-ness for string inference #82

Merged
merged 1 commit into from
Aug 31, 2023
Merged

* fix none-ness for string inference #82

merged 1 commit into from
Aug 31, 2023

Conversation

realratchet
Copy link
Collaborator

Inferring a string type as string should not become a none.

@codecov-commenter
Copy link

Codecov Report

Merging #82 (a1e0e49) into master (3c79d3f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   89.40%   89.39%   -0.02%     
==========================================
  Files          49       49              
  Lines        6761     6763       +2     
==========================================
+ Hits         6045     6046       +1     
- Misses        716      717       +1     
Flag Coverage Δ
pytest 89.39% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tablite/datatypes.py 77.44% <100.00%> (-0.12%) ⬇️
tablite/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@realratchet realratchet merged commit 1446b17 into root-11:master Aug 31, 2023
10 checks passed
realratchet added a commit that referenced this pull request Feb 28, 2024
* fix none-ness for string inference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants