Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby api update #160

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Groupby api update #160

merged 3 commits into from
Apr 5, 2024

Conversation

realratchet
Copy link
Collaborator

There were some breaking issues for dependencies in group by that require the original names for inference of the product column name. Until validation is part of the groupby class itself make it compatible instead.

Also fixes issues when none is passed for tqdm.

Minor cleanup.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (222d900) to head (121af91).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   82.49%   82.62%   +0.13%     
==========================================
  Files          26       26              
  Lines        3884     3873      -11     
==========================================
- Hits         3204     3200       -4     
+ Misses        680      673       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realratchet realratchet merged commit 27f39c6 into root-11:master Apr 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants