Add express-session dependency
#1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
+ Coverage 81.80% 87.37% +5.56%
==========================================
Files 24 25 +1
Lines 3468 3579 +111
==========================================
+ Hits 2837 3127 +290
+ Misses 631 452 -179 ☔ View full report in Codecov by Sentry. |
kethinov
requested changes
Dec 20, 2023
lib/setExpressConfigs.js
Outdated
| secret: 'secret key', | ||
| resave: false, | ||
| saveUninitialized: false | ||
| })) |
There was a problem hiding this comment.
our config would need to be a default config with an option to override it if we do end up doing this
awidener3
changed the title
express-session dependencyexpress-session dependency + --print cli flag
awidener3
changed the title
express-session dependency + --print cli flagexpress-session dependency
kethinov
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
express-sessiondependency insetExpressConfigs.js.