Explicitly require Base64 and CSV #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonoff or @chopraanmol1 can you check this one? ref. #609 |
|
@HashNotAdam can you also add a ruby 3.4 into pipeline? Also, i think would be great to add such gems only after 3.3 ruby. |
HashNotAdam
force-pushed
the
support_ruby_3_4
branch
from
8f8dffb to
50a8aba
Compare
Ruby has been trying to reduce the surface area of the standard library. While Base64 and CSV are default gems, starting with Ruby 3.4,they are no longer included in the standard library and must be explicitly included as dependencies
HashNotAdam
force-pushed
the
support_ruby_3_4
branch
from
50a8aba to
c3b2a7a
Compare
simonoff
reviewed
Jan 26, 2025
| - ruby-head | ||
| - jruby-9.3.3.0 | ||
| - jruby-9.4.10.0 |
There was a problem hiding this comment.
It should be available now, 9.4.10.0 it has been merged and released a few days ago: ruby/setup-ruby/pull/697
Just discovered that there is also 9.4.11.0 ruby/setup-ruby#699
|
@HashNotAdam can you fix jruby version and add a changelog please? |
Faq
approved these changes
Feb 1, 2025
| - ruby-head | ||
| - jruby-9.3.3.0 | ||
| - jruby-9.4.10.0 |
There was a problem hiding this comment.
Suggested change
| - jruby-9.4.10.0 | |
| - jruby-9.4.9.0 |
There was a problem hiding this comment.
As seems v10 not released for ubuntu-24.04 yet.
There was a problem hiding this comment.
In changelog file top, I guess something like:
## Unreleased
### Changed/Added
- Added 'Base64' and 'CSV' as dependencies, both not bundled starting with Ruby 3.4 [604](https://github.com/roo-rb/roo/issues/604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby has been trying to reduce the surface area of the standard library. While Base64 and CSV are default gems, starting with Ruby 3.4, they are no longer included in the standard library and must be explicitly included as dependencies
Other information
Resolves #604