Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ class Excelx < Roo::Base | |||
| require 'roo/excelx/coordinate' | |||
| require 'roo/excelx/format' | |||
|
|
|||
| delegate [:styles, :workbook, :shared_strings, :rels_files, :sheet_files, :comments_files] => :@shared | |||
There was a problem hiding this comment.
I'd actually prefer to used delegate for these methods and delete lines 429-441.
|
Thanks for these changes. Can you keep make the modification I suggested? |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 10, 2016
## [2.3.2] 2016-02-18 ### Fixed - Handle url with long query params (ex. S3 secure url) [302](roo-rb/roo#302) - Allow streaming for Roo::CSV [297](roo-rb/roo#297) - Export Fixnums to Added csv [295](roo-rb/roo#295) - Removed various Ruby warnings [289](roo-rb/roo#289) - Fix incorrect example result in Readme.md [293](roo-rb/roo#293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes several Ruby warnings.