Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0 based sheet numbering #181

Closed
wants to merge 1 commit into from
Closed

Conversation

lipkap
Copy link

@lipkap lipkap commented Mar 10, 2015

Hi - i just came across a weired xlsx where the worksheet xml filenames use zero based numbering:

xl/worksheets/sheet0.xml

while what you 'normally' see is something like:

xl/worksheets/sheet1.xml
xl/worksheets/sheet2.xml
xl/worksheets/sheet3.xml

This pull request contains a v. trivial fix for this

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.69% when pulling 4702b18 on goodylabs:master into 707ed15 on roo-rb:master.

@simonoff
Copy link
Member

@lipkap can you add some test cases?

@lipkap
Copy link
Author

lipkap commented Mar 23, 2015

I will try - The only example sheet i have contains sensitive data that i cannot really share publicly but when I edit and save the worksheets get renumbered :)

@simonoff
Copy link
Member

Ok, good.

@stevendaniels
Copy link
Contributor

#196 should fix this issue.

@lipkap Can you create a gist (sample gist) with that xlsx document so that I can confirm #196 fixes the issue?

Here are some instructions for creating such a gist.

  1. Create a gist with code that creates the error.
  2. Clone the gist repo locally, add a stripped down version of the offending spreadsheet to the gist repo, and push the gist's changes master.
  3. Paste the gist url here.

@stevendaniels
Copy link
Contributor

I'm closing this request. #196 already covers this request, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants