Merge pull request #492 from weilandia/491-fix-bad-link-bug

Closes #491 add nil check for hyperlink['id']
roo-rb · Jan 29, 2019 · faf1b43 · faf1b43
2 parents 4acaef8 + 0479c16
commit faf1b43
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/lib/roo/excelx/relationships.rb b/lib/roo/excelx/relationships.rb
@@ -14,7 +14,7 @@ def to_a
       private
 
       def extract_relationships
-        return [] unless doc_exists?
+        return {} unless doc_exists?
 
         doc.xpath('/Relationships/Relationship').each_with_object({}) do |rel, hash|
           hash[rel['Id']] = rel

diff --git a/test/files/bad_link.xlsx b/test/files/bad_link.xlsx
diff --git a/test/roo/test_excelx.rb b/test/roo/test_excelx.rb
@@ -302,6 +302,11 @@ def test_excelx_links
     end
   end
 
+  def test_handles_link_without_hyperlink
+    workbook = Roo::Spreadsheet.open(File.join(TESTDIR, "bad_link.xlsx"))
+    assert_equal "Test", workbook.cell(1, 1)
+  end
+
   # Excel has two base date formats one from 1900 and the other from 1904.
   # see #test_base_dates_in_excel
   def test_base_dates_in_excelx