Merge pull request #487 from matzko/master

Don't error when there are blank children elements.
roo-rb · Jan 18, 2019 · 2f94d63 · 2f94d63
2 parents e7996b0 + ed09cd1
commit 2f94d63
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/roo/excelx/sheet_doc.rb b/lib/roo/excelx/sheet_doc.rb
@@ -120,7 +120,7 @@ def cell_from_xml(cell_xml, hyperlink, coordinate, empty_cell=true)
           end
         end
 
-        create_empty_cell(coordinate)
+        create_empty_cell(coordinate, empty_cell)
       end
 
       def create_empty_cell(coordinate, empty_cell)

diff --git a/spec/lib/roo/excelx/sheet_doc_spec.rb b/spec/lib/roo/excelx/sheet_doc_spec.rb
@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Roo::Excelx::SheetDoc do
+  subject(:blank_children) { Roo::Excelx.new("test/files/blank_children.xlsx") }
+
+  example "#last_row" do
+    expect(subject.last_row).to eq 3
+  end
+end
diff --git a/test/files/blank_children.xlsx b/test/files/blank_children.xlsx
-Original file line number
+Diff line change
@@ Expand Up @@
               end
             end
-            create_empty_cell(coordinate)
+            create_empty_cell(coordinate, empty_cell)
           end
           def create_empty_cell(coordinate, empty_cell)
@@ Expand Down @@