-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ron does not properly round trip through Value #121
Labels
Comments
It looks even plain tuples don't work: {
let s = ser::to_string(&(1, 1) ).unwrap();
println!("{}", s);
let scene: Value = from_str(&s).unwrap();
println!("{:?}", scene);
} gives:
|
Sounds really strange, I'm gonna look at it tomorrow. Are you sure you're
using a recent version?
|
Yeah this is using 0.3.0. How is it supposed to work? deserialize_any doesn't call deserialize_tuple. |
Huh, it seems there are a couple of things not implemented for values. I'm surprised this wasn't noticed earlier. |
This was referenced Aug 5, 2018
bors bot
added a commit
that referenced
this issue
Aug 7, 2018
124: Handle tuple deserialization in deserialize_any properly r=torkleyy a=torkleyy Fixes #121 Needs some more tests before merging. I'm not happy about all the lookahead that this requires, but I don't see a better solution. Co-authored-by: Thomas Schaller <[email protected]>
I've just merged it, please let me know if there's anything else that's not working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The first example gives:
The second gives:
The text was updated successfully, but these errors were encountered: