Need to set shard info to avoid an NPE

romseygeek · Sep 28, 2023 · 1cab3ba · 1cab3ba
1 parent b357de4
commit 1cab3ba
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
@@ -932,20 +932,16 @@ synchronized void markItemAsDropped(int slot) {
             IndexRequest indexRequest = getIndexWriteRequest(bulkRequest.requests().get(slot));
             failedSlots.set(slot);
             final String id = indexRequest.id() == null ? DROPPED_ITEM_WITH_AUTO_GENERATED_ID : indexRequest.id();
-            itemResponses.add(
-                BulkItemResponse.success(
-                    slot,
-                    indexRequest.opType(),
-                    new IndexResponse(
-                        new ShardId(indexRequest.index(), IndexMetadata.INDEX_UUID_NA_VALUE, 0),
-                        id,
-                        SequenceNumbers.UNASSIGNED_SEQ_NO,
-                        SequenceNumbers.UNASSIGNED_PRIMARY_TERM,
-                        indexRequest.version(),
-                        DocWriteResponse.Result.NOOP
-                    )
-                )
+            IndexResponse ir = new IndexResponse(
+                new ShardId(indexRequest.index(), IndexMetadata.INDEX_UUID_NA_VALUE, 0),
+                id,
+                SequenceNumbers.UNASSIGNED_SEQ_NO,
+                SequenceNumbers.UNASSIGNED_PRIMARY_TERM,
+                indexRequest.version(),
+                DocWriteResponse.Result.NOOP
             );
+            ir.setShardInfo(new ReplicationResponse.ShardInfo(0, 0));
+            itemResponses.add(BulkItemResponse.success(slot, indexRequest.opType(), ir));
         }
 
         synchronized void markItemAsFailed(int slot, Exception e) {