This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
add rule noArrayIndexKey #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorHom
force-pushed
the
victorhom/rule/noArrayIndexKey
branch
2 times, most recently
from
008729a to
00f1212
Compare
sebmck
suggested changes
Jun 13, 2020
VictorHom
force-pushed
the
victorhom/rule/noArrayIndexKey
branch
2 times, most recently
from
6c9def5 to
405d5c5
Compare
remove as type and add feedback change to noArrayIndexKey
VictorHom
force-pushed
the
victorhom/rule/noArrayIndexKey
branch
from
405d5c5 to
97da558
Compare
|
Looks good. I'm concerned about the fragility of the static analysis but seems like it's inline with the eslint rule so it's good for now. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noArrayIndexKey
#341