Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_cli): print the correct subcommand in error messages #3460

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix(rome_cli): print the correct subcommand in error messages #3460

merged 1 commit into from
Oct 20, 2022

Conversation

lucasweng
Copy link
Contributor

Summary

  • Resolves the issue that the error messages in rome check and rome ci incorrectly refer to the rome format command
❯ cargo run --bin rome ci --quote-style="double" 
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/rome ci --quote-style=double`
Error: missing argument '<INPUT>'. Type 'rome format --help' for more information.

Test Plan

  • Running rome check or rome ci with one argument missing or unsupported options and the error message should infer the subcommand
    error_message1
    error_message2

@lucasweng lucasweng requested a review from leops as a code owner October 20, 2022 02:20
@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit b0aa27b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6350b19e08f8000008ad8e3d
😎 Deploy Preview https://deploy-preview-3460--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@MichaReiser MichaReiser added the A-CLI Area: CLI label Oct 20, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 20, 2022
@MichaReiser MichaReiser added the hacktoberfest Issues for hacktoberfest label Oct 20, 2022
@MichaReiser MichaReiser merged commit 1ad7ad2 into rome:main Oct 20, 2022
@lucasweng lucasweng deleted the fix/cli-error-messages branch October 20, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI hacktoberfest Issues for hacktoberfest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants