-
Notifications
You must be signed in to change notification settings - Fork 660
feat(rome_js_formatter): Call arguments formatting #3290
Conversation
✅ Deploy Preview for rometools canceled.
|
125dd00
to
bf405d9
Compare
!bench_formatter |
Formatter Benchmark Results
|
9623824
to
8cee5d6
Compare
!bench_formatter |
Comparing feat(rome_js_formatter): Call arguments formatting Snapshot #14 to median since last deploy of rome.tools.
1 page testedHomeBrowser previews
Most significant changes28 other significant changes: JS Parse & Compile on Chrome Desktop, First Contentful Paint on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Motorola Moto G Power, 3G connection, Speed Index on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Time to Interactive on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, First Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Speed Index on iPhone, 4G LTE, Time to Interactive on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Total Blocking Time on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Chrome Desktop, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop Calibre: Site dashboard | View this PR | Edit settings | View documentation |
Formatter Benchmark Results
|
crates/rome_js_formatter/src/js/expressions/arrow_function_expression.rs
Show resolved
Hide resolved
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Summary
This PR improves our formatting of call arguments:
test
method (beforeEach
,it
, ...)compose(sortBy(x => x), flatten, map(x => [x, x*2]));
Test Plan
Average compatibility: 89.48 -> 91.72%
Compatible lines: 90.47 -> 93.49%