This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): variable declarator formatting #2762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially implements #2423
Prev PR with discussion: #2737
current:
File Based Average Prettier Similarity: 76.28%
Line Based Average Prettier Similarity: 70.99%
main:
File Based Average Prettier Similarity: 75.24%
Line Based Average Prettier Similarity: 70.33%
This PR adds
OnlyLeft
layout to the list of layouts. This layout is hit, usually, when variable declarator doesn't have initializer.should_break_left_hand_side
when variable declarationhas_complex_type_annotation
. Prettier hasComplexTypeAnnotation.should_not_indent_if_parent_indents
. Don't indent ifgreat_parent
isJS_VARIABLE_DECLARATOR
.Test Plan
Add new tests specs