Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Add linter rule: no function reassignment #130

Merged
merged 6 commits into from
Mar 4, 2020

Conversation

wgardiner
Copy link
Contributor

Adds linter rule for no function reassignment

@facebook-github-bot
Copy link

Hi @wgardiner!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sebmck sebmck mentioned this pull request Mar 4, 2020
27 tasks
Copy link
Contributor

@sebmck sebmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Everything looks good except for the tests. Use for...of instead of forEach. The usage of forEach here is incorrect since the callback is an async function. It will create a bunch of unhandled promises and it wont be handled by the test callback.

packages/@romejs/js-compiler/__rtests__/lint.ts Outdated Show resolved Hide resolved
packages/@romejs/js-compiler/__rtests__/lint.ts Outdated Show resolved Hide resolved
wgardiner and others added 2 commits March 4, 2020 14:21
no function assign lint rule switch test to use for ... of

Co-Authored-By: Sebastian <[email protected]>
no function assign lint rule switch test to use for ... of

Co-Authored-By: Sebastian <[email protected]>
@wgardiner wgardiner requested a review from sebmck March 4, 2020 19:46
@sebmck sebmck merged commit e3a88b9 into rome:master Mar 4, 2020
@sebmck
Copy link
Contributor

sebmck commented Mar 4, 2020

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants