-
Notifications
You must be signed in to change notification settings - Fork 657
Add linter rule: no function reassignment #130
Conversation
Hi @wgardiner! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Everything looks good except for the tests. Use for...of
instead of forEach
. The usage of forEach
here is incorrect since the callback is an async function. It will create a bunch of unhandled promises and it wont be handled by the test callback.
no function assign lint rule switch test to use for ... of Co-Authored-By: Sebastian <[email protected]>
no function assign lint rule switch test to use for ... of Co-Authored-By: Sebastian <[email protected]>
Thank you! |
Adds linter rule for no function reassignment