This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add disallowVar lint rule #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
commented
Mar 2, 2020
| import {Path} from '@romejs/js-compiler'; | ||
|
|
||
| const DEFAULT_BASENAME_MESSAGE = | ||
| 'Variable declarations using `var` are disallowed, use `let` or `const` instead.'; |
There was a problem hiding this comment.
Possible improvement: Automatically suggest let or const based on how the variable is currently used (or at least refine down to just let if it gets reassigned). If the variable isn't used yet (which will happen often when linting while typing) it could use the default message.
sebmck
reviewed
Mar 2, 2020
|
Missing a test, otherwise looks good. |
jamiebuilds
force-pushed
the
disallowVar
branch
3 times, most recently
from
576aebf to
b1960dd
Compare
jamiebuilds
commented
Mar 2, 2020
| var littleOffset = 26; | ||
| var numberOffset = 52; | ||
| const littleOffset = 26; | ||
| const numberOffset = 52; |
There was a problem hiding this comment.
Adding this lint rule caught some stuff
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just going through the list here: #20 (comment) Wanted to grab something easy.