Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

adds noLabelVar to linter #102

Merged
merged 2 commits into from
Mar 2, 2020
Merged

adds noLabelVar to linter #102

merged 2 commits into from
Mar 2, 2020

Conversation

gobeli
Copy link

@gobeli gobeli commented Mar 2, 2020

Adds no-label-var check for #94
Maybe also check for BROWSER / NODE / JEST - Variables?

@facebook-github-bot
Copy link

Hi @gobeli!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sebmck sebmck merged commit 602ea84 into rome:master Mar 2, 2020
@sebmck
Copy link
Contributor

sebmck commented Mar 2, 2020

Perfect! Thank you!

Maybe also check for BROWSER / NODE / JEST - Variables?

We should probably move that out of the specific undeclaredVariables rule into some logic in isGlobal, and add some way of specifying an environment.

@sebmck sebmck mentioned this pull request Mar 2, 2020
27 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants