☂️ Formatter 0.9.0

[MichaReiser]

Description

This is an umbrella issue for the work on the Formatter for the 0.9.0 release.

Goals

• Rome removes unnecessary parentheses and adds parentheses to improve readability.
• Improve Prettier compatibility of some core syntax nodes.

Tasks

• Parentheses (2 weeks) Parenthesized binary expression #2427
  • Implement parentheses handling for expressions feat(rome_js_formatter): Parenthesizing expressions #3057, feat(rome_js_formatter): Binary expression formatting #3079 Parenthesize expressions #2449
  • Implement parentheses handling for assignments feat(rome_js_formatter): Parenthesize assignments #3083
  • Implement parentheses handling for types feat(rome_js_formatter): Parenthesize TypeScript types #3108
  • Remove parenthesized nodes from formatting tree feat(rome_js_formatter): Preprocess AST before formatting #3092
• Prettier compatibility (2 weeks)
  • JsConditionalExpression
  • Hug function parameters
  • Parameter and return type formatting
  • return and throw argument
  • JsTemplate Template literal formatting #2446 feat(rome_js_formatter): Template formatting #3063
  • JsBinaryExpression feat(rome_js_formatter): Binary expression formatting #3079
  • JsArrowFunctionExpression feat(rome_js_formatter): Format Arrow Chains #3122
  • JsArrayExpression feat(rome_js_formatter): Heuristic for fill arrays #3126
  • JsStaticMemberAssignment and JsComputedMemberAssignment feat(rome_js_formatter): Member assignment formatting #3061
  • JSX formatting feat(rome_js_formatter): Format JSX #3144
  • JSX in Conditional Expressions feat(rome_js_formatter): Conditional JSX Chain layout #3150

[ematipico]

This is a follow up question after #3057.

Is there a specific reason why the "needs parentheses" information is tracked inside the formatter phase?

Have you considered some other solutions, such as a visitor approach, or even computing this information during the parsing phase and storing it inside our green tree?

I would like to know what are the implications of your decisions in the future developments

[MichaReiser]

@ematipico I replied on the PR as these questions seem relevant to the implementation.

[MichaReiser]

I start working on the Arrow function formatting

[MichaReiser]

I'll start looking into JSX formatting tomorrow

[IWANABETHATGUY]

We are getting close to 90% prettier compatibility, that's awesome.