Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

☂️ Prettier Formatting compatibility #2403

Closed
45 tasks done
MichaReiser opened this issue Apr 13, 2022 · 5 comments
Closed
45 tasks done

☂️ Prettier Formatting compatibility #2403

MichaReiser opened this issue Apr 13, 2022 · 5 comments
Assignees
Labels
A-Formatter Area: formatter umbrella Issue to track a collection of other issues

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Apr 13, 2022

Description

Rome formatter's goal is to match Prettier's formatting as closely as possible where reasonable, and we have no good reasons to deviate.

This umbrella task tracks the syntaxes that Rome formats differently than prettier.

Statements

Module Items

Expressions

Assignment

Functions

TypeScript

Literals

Infrastructure

Report of all tests that Rome formats differently than Prettier (created on the 12th of April 22).

@MichaReiser MichaReiser added the umbrella Issue to track a collection of other issues label Apr 13, 2022
@ematipico ematipico added the A-Formatter Area: formatter label Apr 13, 2022
@MichaReiser
Copy link
Contributor Author

I haven't gone through the TypeScript reports yet. Something we should do in the near future

@MichaReiser MichaReiser changed the title 📎 Prettier Formatting compatibility 📎 Prettier JS Formatting compatibility Apr 14, 2022
@MichaReiser MichaReiser changed the title 📎 Prettier JS Formatting compatibility 📎 Prettier Formatting compatibility Apr 14, 2022
@ematipico ematipico pinned this issue Apr 28, 2022
@yassere yassere changed the title 📎 Prettier Formatting compatibility ☂️ Prettier Formatting compatibility May 8, 2022
@hustcer
Copy link

hustcer commented Jul 5, 2022

Any update on this issue after the latest 0.7.0 release?

@ematipico
Copy link
Contributor

Any update on this issue after the latest 0.7.0 release?

The current update is exactly what you see in the description of the issue. Many tasks have been closed and the compatibility is getting closer. The main things to close the gap are parenthesis and member chain.

@harrytran998
Copy link

Happy when I see only 10 checkboxes 😂. Your team has worked really hard! 🙏

@ematipico ematipico unpinned this issue Aug 3, 2022
@ematipico ematipico self-assigned this Aug 4, 2022
@ematipico ematipico moved this to In Progress in Rome 2022 Aug 4, 2022
@MichaReiser
Copy link
Contributor Author

Closing in favour of #3046 and #3047

Repository owner moved this from In Progress to Done in Rome 2022 Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter umbrella Issue to track a collection of other issues
Projects
Status: Done
Development

No branches or pull requests

4 participants