Merge branch 'master' into sparse-array

rome · Mar 3, 2020 · f712518 · f712518
2 parents a27e672 + 741e6f9
commit f712518
Show file tree

Hide file tree

Showing 2,329 changed files with 31,580 additions and 29,634 deletions.
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
@@ -4,6 +4,8 @@ We can use help in a bunch of areas and any help is appreciated. Our [GitHub iss
 
 Our [Discord server](https://discord.gg/9WxHa5d) is open for help and more adhoc discussion. All activity on the Discord is still moderated and will be strictly enforced under the project's [Code of Conduct](./CODE_OF_CONDUCT.md).
 
+You have to sign the [contributor license agreement (CLA)](https://code.facebook.com/cla) before your pull request can be reviewed. 
+
 ## Getting Started
 
 Getting started with developing Rome is as easy as three commands. You will need Node v12 or above.
@@ -16,7 +18,7 @@ scripts/dev-rome --help
 
 No dependency installation step is required as we check in our `node_modules` folder that contains only a copy of TypeScript and some definitions.
 
-Refer to [Getting Started](../website/docs/introduction/getting-started.md) for more usage documentation.
+Refer to [Getting Started](https://romejs.dev/docs/introduction/getting-started/) for more usage documentation.
 
 ## Testing
 
@@ -35,3 +37,19 @@ Run TypeScript with code emitting disabled to perform a full typecheck outside t
 ```bash
 node_modules/.bin/tsc --noEmit
 ```
+
+## Developing on Windows
+
+You may run into errors when trying to run the Rome commands on Windows
+
+```
+PS C:\code\rome> scripts/dev-rome --help
+ResourceUnavailable: Program 'dev-rome' failed to run: No application is associated with the specified file for this operation.At line:1 char:1
++ scripts/dev-rome --help
++ ~~~~~~~~~~~~~~~~~~~~~~~.
+```
+
+This is because the command uses shebangs to automatically invoke itself as a Node script. You can fix this in a couple of ways:
+
+- Use a terminal that supports shebangs on Windows such a Git Bash
+- Prefix any commands with `node` eg. `node scripts/dev-rome`
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -36,15 +36,19 @@ jobs:
 
   tests:
     name: Tests
-    runs-on: ubuntu-latest
     needs: [lint]
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
 
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
           node-version: '13.x'
       - name: Run tests
+        shell: bash
         run: ./scripts/dev-rome test
 
   build:

diff --git a/README.md b/README.md
@@ -50,7 +50,7 @@ $ echo '{}' >rome.json
 
 This file is used to configure Rome and indicates the boundaries of your project.
 
-See [Getting Started](website/docs/introduction/getting-started.md) for more usage instructions.
+See [Getting Started](https://romejs.dev/docs/introduction/getting-started/) for more usage instructions.
 
 ## Philosophy
 

diff --git a/hello.js b/hello.js
diff --git a/node_modules/@types/node/README.md b/node_modules/@types/node/README.md
diff --git a/node_modules/@types/node/assert.d.ts b/node_modules/@types/node/assert.d.ts
diff --git a/node_modules/@types/node/async_hooks.d.ts b/node_modules/@types/node/async_hooks.d.ts
diff --git a/node_modules/@types/node/buffer.d.ts b/node_modules/@types/node/buffer.d.ts