Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Commit

Permalink
fix conflicts and apply feedback for noDidUpdateSetState
Browse files Browse the repository at this point in the history
  • Loading branch information
Victor Hom committed May 17, 2020
1 parent 1ad08ae commit b6d2c7a
Show file tree
Hide file tree
Showing 7 changed files with 117 additions and 1,023 deletions.
64 changes: 2 additions & 62 deletions packages/@romejs/diagnostics/categories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ export type DiagnosticCategoryPrefix =
// EVERYTHING BELOW IS AUTOGENERATED. SEE SCRIPTS FOLDER FOR UPDATE SCRIPTS

type LintDiagnosticCategory =
<<<<<<< HEAD
| "lint/camelCase"
| "lint/camelCase"
| "lint/caseSingleStatement"
| "lint/confusingLanguage"
| "lint/defaultExportSameBasename"
Expand Down Expand Up @@ -122,6 +121,7 @@ type LintDiagnosticCategory =
| "lint/noDebugger"
| "lint/noDelete"
| "lint/noDeleteVars"
| "lint/noDidUpdateSetState"
| "lint/noDupeArgs"
| "lint/noDuplicateCase"
| "lint/noDuplicateGroupNamesInRegularExpressions"
Expand Down Expand Up @@ -156,63 +156,3 @@ type LintDiagnosticCategory =
| "lint/unsafeNegation"
| "lint/unusedVariables"
| "lint/voidDomElementsNoChildren";
=======
| 'lint/camelCase'
| 'lint/caseSingleStatement'
| 'lint/defaultExportSameBasename'
| 'lint/doubleEquals'
| 'lint/duplicateImportSource'
| 'lint/emptyBlocks'
| 'lint/emptyMatches'
| 'lint/getterReturn'
| 'lint/importDefaultBasename'
| 'lint/inconsiderateLanguage'
| 'lint/jsxKey'
| 'lint/jsxNoCommentText'
| 'lint/negationElse'
| 'lint/noArguments'
| 'lint/noAsyncPromiseExecutor'
| 'lint/noCatchAssign'
| 'lint/noChildrenProp'
| 'lint/noCommaOperator'
| 'lint/noCompareNegZero'
| 'lint/noCondAssign'
| 'lint/noDangerWithChildren'
| 'lint/noDebugger'
| 'lint/noDelete'
| 'lint/noDeleteVars'
| 'lint/noDidUpdateSetState'
| 'lint/noDupeArgs'
| 'lint/noDuplicateCase'
| 'lint/noDuplicateGroupNamesInRegularExpressions'
| 'lint/noDuplicateKeys'
| 'lint/noEmptyCharacterClass'
| 'lint/noExplicitAny'
| 'lint/noExtraBooleanCast'
| 'lint/noFunctionAssign'
| 'lint/noImportAssign'
| 'lint/noLabelVar'
| 'lint/noMultipleSpacesInRegularExpressionLiterals'
| 'lint/noPosixInRegularExpression'
| 'lint/noReferenceToNonExistingGroup'
| 'lint/noSetterReturn'
| 'lint/noShadowRestrictedNames'
| 'lint/noShorthandArrayType'
| 'lint/noTemplateCurlyInString'
| 'lint/noUnsafeFinally'
| 'lint/noVar'
| 'lint/preferBlockStatements'
| 'lint/preferFunctionDeclarations'
| 'lint/preferTemplate'
| 'lint/preferWhile'
| 'lint/reactInJsxScope'
| 'lint/restrictedGlobals'
| 'lint/singleVarDeclarator'
| 'lint/sortImportExportSpecifiers'
| 'lint/sparseArray'
| 'lint/stylePropObject'
| 'lint/undeclaredVariables'
| 'lint/unsafeNegation'
| 'lint/unusedVariables'
| 'lint/voidDomElementsNoChildren';
>>>>>>> add rule for no setState in componentDidUpdate and tests
Loading

0 comments on commit b6d2c7a

Please sign in to comment.