Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add promise support to <If /> component (fixes #53) #111

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

theo-js
Copy link
Contributor

@theo-js theo-js commented Sep 26, 2021

Hello, with this PR, the If component would be able to support Promises.
I've added an example to the demo, you can read the update to README.md for the API details

@theo-js theo-js requested review from favna and romac as code owners September 26, 2021 14:11
@favna favna force-pushed the ifAsyncSupport branch 2 times, most recently from 74f6d70 to 1c15b40 Compare September 26, 2021 20:11
@favna favna changed the title feat: add promise support to <If /> component (solves #53) feat: add promise support to <If /> component (fixes #53) Sep 26, 2021
@favna favna merged commit 18bb83b into romac:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants