Hw04 #41
Open
Hw04 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romabelka
reviewed
Oct 29, 2018
| @@ -22,11 +22,11 @@ export class ArticleList extends Component { | |||
|
|
|||
| get items() { | |||
| const { articles, openItemId, toggleOpenItem } = this.props | |||
| return articles.map((article) => ( | |||
| <li key={article.id} className="test--article-list__item"> | |||
| return Object.keys(articles).map((id) => ( | |||
There was a problem hiding this comment.
Лучше селектор, который достанет их в виде массива
| import { ADD_COMMENT } from '../constants' | ||
|
|
||
| export default (store) => (next) => (action) => { | ||
| if (action.type === ADD_COMMENT) { |
There was a problem hiding this comment.
через мидлвары будет проходить каждый экшин, они должны быть максимально общими, завязывать на конкретные экшины - не лучшее решение
|
|
||
| export default (store) => (next) => (action) => { | ||
| if (action.type === ADD_COMMENT) { | ||
| action.payload.comment.id = Math.random() |
There was a problem hiding this comment.
лучше не мутировать payload, мало-ли что там станут передавать
| ...result[payload.comment.articleId] | ||
| } | ||
| // создали поверхностную копию | ||
| result[payload.comment.articleId].comments.push(payload.comment.id) |
There was a problem hiding this comment.
здесь ты мутируешь стейт. Возвращаешь новый объект, но внутри меняешь объекты по ссылке
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homewrok 04 realized