Homework - 3 #29
Open
Homework - 3 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romabelka
reviewed
Oct 22, 2018
| @@ -12,3 +12,10 @@ export function deleteArticle(id) { | |||
| payload: { id } | |||
| } | |||
| } | |||
|
|
|||
| export function setFilter(filter) { | |||
There was a problem hiding this comment.
Лучше отдельно обрабатывать селект и дату, я бы делал 2 отдельных AC
| @@ -0,0 +1,70 @@ | |||
| import React, { Component } from 'react' | |||
|
|
|||
| const filterDecorator = (OriginalComponent, listName) => | |||
There was a problem hiding this comment.
Идея хорошая, но немного оверхед. Покажу как проще можно было
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Вынесла Фильтр для article-list в filterDecorator.
Он получился достаточно универсальным (каким и должен быть декоратор, ведь так?), т.е. filterDecorator можно применить не только к article-list, но и к любому спископодобному компоненту (authorList, userList catList and etc), который надо отфильтровать и не важно что это будет за фильтр: по селекту или фильтр по дате, или может чекбокс для которого можно будет добавить бизнес-логику в filterDecorator позже.
Вопрос: это ok или это too much for decorator и я вообще ничего не поняла про декораторы.