-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more explained error code for name-less umd bundle #3393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in favor of this change. It's still too vague in the larger context of Rollup, and if we're going to make a breaking change then a clear, concise, explanatory error code should be chosen.
@shellscape What would be your suggestion? For me, the important part is that it should be aligned with the same error code for IIFE which is added in #3372. The error is that the |
1e393ef
to
8362f5b
Compare
85134f4
to
b5fc1f1
Compare
I have changed the error code as suggested by me and also further extended the error message to explain why we need a name at all (and we have an IIFE error for UMD bundles). @shellscape would this work for you so that we can proceed here? |
…these messages as of course it makes sense CircleCI does not expose the token for different repo PRs for security reasons. Babel is using an AWS Lambda here, maybe something like that.
Codecov Report
@@ Coverage Diff @@
## release-2.0.0 #3393 +/- ##
=============================================
Coverage 95% 95%
=============================================
Files 171 171
Lines 5801 5801
Branches 1712 1712
=============================================
Hits 5511 5511
Misses 157 157
Partials 133 133
Continue to review full report at Codecov.
|
* more explained error code for name-less umd bundle * Align error code with IIFE warning * Fix missing auth token issue. I guess we need to rethink how we post these messages as of course it makes sense CircleCI does not expose the token for different repo PRs for security reasons. Babel is using an AWS Lambda here, maybe something like that. Co-authored-by: Lukas Taegert-Atkinson <[email protected]>
* more explained error code for name-less umd bundle * Align error code with IIFE warning * Fix missing auth token issue. I guess we need to rethink how we post these messages as of course it makes sense CircleCI does not expose the token for different repo PRs for security reasons. Babel is using an AWS Lambda here, maybe something like that. Co-authored-by: Lukas Taegert-Atkinson <[email protected]>
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
refs #3372
In above PR, I was suggested to tweak error code for UMD bundle.
Because this patch will be breaking change for people already using this code in plugins, I create PR based on
release-2.0.0
.