Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

fix: use fs.mkdir to instead of mkpath as it was not maintained #24

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

kuitos
Copy link
Contributor

@kuitos kuitos commented Oct 7, 2019

see jonvuri/mkpath#6


This change is Reviewable

@kuitos
Copy link
Contributor Author

kuitos commented Oct 7, 2019

more detail scenario https://travis-ci.org/umijs/father/jobs/591324449#L285

@Ashot-KR could you pls donate some time to review it?

@Ashot-KR
Copy link

Ashot-KR commented Oct 7, 2019

@kuitos reviewed already. I will merge it and publish new version later today.

@Ashot-KR Ashot-KR merged commit 3974d44 into rollup:master Oct 8, 2019
@Ashot-KR
Copy link

Ashot-KR commented Oct 8, 2019

2.2.3 published on npm

@Ashot-KR
Copy link

Ashot-KR commented Oct 8, 2019

@kuitos looks like it broke plugin on node <=8 :bowtie:
now version 2.2.3 marked as deprecated
version 2.2.4 uses mkdirp package for node <=8
version 3.0.0 uses your changes and required node >=10 – please use this version (also it migrated to MIT lisense)

@kuitos
Copy link
Contributor Author

kuitos commented Oct 8, 2019

Thanks for your great efforts!
I am wonder what behavior broke the plugin on node <=8 🤔
I had checked the version history of fs.mkdir before, it added after v0.1.8, the very early version
see https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback

@Ashot-KR
Copy link

Ashot-KR commented Oct 8, 2019

@kuitos It was surprise for me too.
Problem was that recursive option for fs.mkdir was added in node 10
in node 8 and earlier second parameter was mode https://nodejs.org/docs/latest-v8.x/api/fs.html#fs_fs_mkdir_path_mode_callback

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants