Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Support preserveSymlinks: false (fixes #400) #401

Merged
merged 5 commits into from
Aug 3, 2019

Conversation

bterlson
Copy link
Contributor

@bterlson bterlson commented Aug 2, 2019

Let me know if there is anything else required here!

Fixes #400.

@bterlson
Copy link
Contributor Author

bterlson commented Aug 2, 2019

I'm not sure why my test is failing in appveyor - it passes locally (on windows, in node 8, 10, and 12). Appreciate any thoughts on how to fix it while I ponder...

The error is:

  1) rollup-plugin-commonjs
       misc tests
         handles symlinked node_modules with preserveSymlinks: false:
     Error: Unexpected token (Note that you need plugins to import files that are not JavaScript)
      at error (node_modules\rollup\dist\rollup.js:9396:30)
      at Module.error (node_modules\rollup\dist\rollup.js:13333:9)
      at tryParse (node_modules\rollup\dist\rollup.js:13248:16)
      at Module.setSource (node_modules\rollup\dist\rollup.js:13564:33)
      at Promise.resolve.catch.then.then.then (node_modules\rollup\dist\rollup.js:16350:20)
      at <anonymous>

@bterlson
Copy link
Contributor Author

bterlson commented Aug 2, 2019

Looks like the issue was that core.symlinks isn't enabled by default in git for windows. Once enabled, it looks like everything passes! 🎉

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -6,6 +6,7 @@ clone_depth: 10

init:
- git config --global core.autocrlf false
- git config --global core.symlinks true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice you found this! This could be useful for Rollup core as well.

@lukastaegert lukastaegert merged commit 8f91234 into rollup:master Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namedExports doesn't work with symlinked node_modules
2 participants