Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

namedExports doesn't work with symlinked node_modules #400

Closed
bterlson opened this issue Aug 2, 2019 · 0 comments · Fixed by #401
Closed

namedExports doesn't work with symlinked node_modules #400

bterlson opened this issue Aug 2, 2019 · 0 comments · Fixed by #401

Comments

@bterlson
Copy link
Contributor

bterlson commented Aug 2, 2019 •
edited
Loading

If you pass preserveSymlinks: false to rollup-plugin-node-resolve, and your node_modules directory's contents are symlinked, then the namedExports config key doesn't work properly. This plugin creates a map with keys containing symlinked paths, whereas rollup asks it about real paths.

I found this because resolve 1.11.1 had a bug in its preserveSymlinks: false behavior where it would not realpath some symlinks. With that fixed in 1.12.0, namedExports stopped working.

I'm happy to write up a PR for fixing this if needed. Maybe can realpath the result of resolve and map that as well.
@ljharb ljharb mentioned this issue Aug 2, 2019
Merged
@mikeharder mikeharder mentioned this issue Aug 2, 2019
Merged
bterlson added a commit to bterlson/rollup-plugin-commonjs that referenced this issue Aug 2, 2019
@bterlson
Support preserveSymlinks: false (fixes rollup#400)
2f4cba5
@bterlson bterlson mentioned this issue Aug 2, 2019
Merged
lukastaegert pushed a commit that referenced this issue Aug 3, 2019
@bterlson @lukastaegert
Support preserveSymlinks: false (fixes #400) (#401)
8f91234 
* Support preserveSymlinks: false (fixes #400)

* remove only

* Promise.prototype.finally is too new

* Only realpath existing paths

* Update appveyor to ensure symlinks are enabled
mikeharder added a commit to Azure/azure-sdk-for-js that referenced this issue Aug 7, 2019
@mikeharder
Remove dedupe from rollup config (#4613)
a8faa8b 
- Update transitive dependency resolve to 1.12.0
  - Fixes issue with symlink resolution which required dedupe workaround
  - browserify/resolve#196
- Depends on [email protected]
  - Supports preserveSymlinks:false
  - rollup/rollup-plugin-commonjs#400
- Move buffer to full dependency of service-bus
  - Packages required for browser bundles should be full dependencies
  - Improves customer experience when generating bundles from our packages
- Add dependencies buffer and process to event-hubs
  - Required to generate browser bundle
- Fixes #3326
@bterlson bterlson mentioned this issue Aug 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support preserveSymlinks: false (fixes #400) bterlson/rollup-plugin-commonjs
1 participant
@bterlson