Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

support absolute alias + fix extension appending #2

Merged
merged 1 commit into from
Apr 23, 2016
Merged

support absolute alias + fix extension appending #2

merged 1 commit into from
Apr 23, 2016

Conversation

yyx990803
Copy link
Contributor

Currently aliasing to absolute paths is broken. Also, when the import path already includes the .js extension, it is still incorrectly appended.

This commit fixes both.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 97.727% when pulling d1b4f43 on yyx990803:master into 4e6c1f3 on frostney:master.

@frostney
Copy link
Contributor

Thank you so much for this. 👍

@frostney frostney merged commit ea0bd01 into rollup:master Apr 23, 2016
@frostney
Copy link
Contributor

This just landed with 1.2.0.
I was a bit on the fence if it should be a new major (breaking) version number. Since I didn't intend for absolute paths before, I felt being bumping just the minor version indicating a new feature is a better fit.

@yyx990803
Copy link
Contributor Author

I don't think this would break anything, minor bump seems appropriate.

@lukeapage lukeapage mentioned this pull request Jun 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyx990803 @coveralls @frostney