feat(node-resolve): add rootDir option #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating this. It looks like the ESLint TS plugin is on the fritz again. I'll try to fix that in the next day or so. |
LarsDenBakker
force-pushed
the
feat/root-dir
branch
2 times, most recently
from
578c09a to
1515fce
Compare
LarsDenBakker
force-pushed
the
feat/root-dir
branch
from
1515fce to
af87977
Compare
NotWoods
requested changes
Dec 22, 2019
Co-Authored-By: Tiger Oakes <[email protected]>
|
|
shellscape
approved these changes
Dec 25, 2019
|
|
LarsDenBakker
added a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* feat(node-resolve): add rootDir option * chore: update .eslintignore for new fixtures * test: add missing snapshots * Update packages/node-resolve/README.md Co-Authored-By: Tiger Oakes <[email protected]> * test(node-resolve): remove test.only Co-authored-by: Andrew Powell <[email protected]> Co-authored-by: Tiger Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: fixes #86
Description
Introduces a
rootDiroption, which is used to resolve modules which need to imported from root. Right now these are entrypoint modules and deduped modules. The default value isprocess.cwd(), which is also what it used right now making this a non-breaking change.