-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): Add typechecking! #177
Conversation
ec3fa3c
to
0af29fb
Compare
0af29fb
to
9fb28fb
Compare
@NotWoods if this looks good to you, merge it. Which semver are you thinking for this, minor or major? |
I'm thinking of major just to be safe. The new feature is fairly large so it makes sense as a major change. |
Nice work! One question (admittedly without checking your code): Will it still be possible to use the "old" style transformations via option? I definitely think that type-checking should be enabled by default, but the old way is still probably faster and may have other advantages for development (though it does not support But I do not see it as a "must have"
For that reason I agree that it should be major as it is breaking for people relying on this plugin compiling their broken types 😜 |
I plan to add the old style back in through a separate PR: https://github.com/rollup/plugins/compare/ts-type-check...NotWoods:ts-diagnostic-categories?expand=1 |
Should that option be included here to make migration easier? |
Not for me, you can always hold back on upgrading if it is on the roadmap |
cd63d3c
to
98990a2
Compare
BREAKING CHANGE: This enables type checking, which will prevent builds with type errors from succeeding. * feat(typescript): Add typechecking * chore(release): pluginutils v3.0.5 Co-authored-by: Andrew Powell <[email protected]>
Rollup Plugin Name:
typescript
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #71, #105, #153
Description
Adds full typechecking support to the official Typescript plugin!