chore: Always lint types folder

rollup · Feb 28, 2020 · 4c04579 · 4c04579
1 parent d8c6ebe
commit 4c04579
Show file tree

Hide file tree

Showing 37 changed files with 105 additions and 134 deletions.
diff --git a/package.json b/package.json
@@ -6,9 +6,10 @@
     "ci:coverage:submit": "node scripts/codecov",
     "ci:lint": "node scripts/run-changed.js ci:lint",
     "ci:test": "node scripts/run-changed.js ci:test",
-    "lint": "pnpm run lint:docs && pnpm run lint:package && node scripts/run-changed.js lint",
-    "lint:docs": "prettier --write README.md",
+    "lint": "pnpm run lint:docs && npm run lint:json && pnpm run lint:package && node scripts/run-changed.js lint",
+    "lint:docs": "prettier --single-quote --write README.md",
     "lint:js": "eslint scripts util",
+    "lint:json": "prettier --single-quote --write tsconfig.*.json codecov.yml pnpm-workspace.yaml",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "preinstall": "node scripts/disallow-npm.js",
     "pub": "node scripts/pub.js",

diff --git a/packages/alias/package.json b/packages/alias/package.json
@@ -22,7 +22,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
+    "lint:js": "eslint --fix --cache src test types --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/alias/tsconfig.json b/packages/alias/tsconfig.json
@@ -1,9 +1,5 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    "lib": ["es6"],
-    "module": "esnext"
-  },
   "include": [
     "src/**/*",
     "types/**/*"

diff --git a/packages/alias/types/index.d.ts b/packages/alias/types/index.d.ts
@@ -1,35 +1,35 @@
 import { Plugin, ResolveIdResult } from 'rollup';
 
 export interface Alias {
-    find: string | RegExp;
-    replacement: string;
-    customResolver?: ResolverFunction | ResolverObject | null;
+  find: string | RegExp;
+  replacement: string;
+  customResolver?: ResolverFunction | ResolverObject | null;
 }
 
 export type ResolverFunction = (
-    source: string,
-    importer: string | undefined
+  source: string,
+  importer: string | undefined
 ) => Promise<ResolveIdResult> | ResolveIdResult;
 
 export interface ResolverObject {
-    resolveId: ResolverFunction;
+  resolveId: ResolverFunction;
 }
 
 export interface RollupAliasOptions {
-    /**
-     * Instructs the plugin to use an alternative resolving algorithm,
-     * rather than the Rollup's resolver.
-     * @default null
-     */
-    customResolver?: ResolverFunction | ResolverObject | null;
+  /**
+   * Instructs the plugin to use an alternative resolving algorithm,
+   * rather than the Rollup's resolver.
+   * @default null
+   */
+  customResolver?: ResolverFunction | ResolverObject | null;
 
-    /**
-     * Specifies an `Object`, or an `Array` of `Object`,
-     * which defines aliases used to replace values in `import` or `require` statements.
-     * With either format, the order of the entries is important,
-     * in that the first defined rules are applied first.
-     */
-    entries?: readonly Alias[] | { [find: string]: string };
+  /**
+   * Specifies an `Object`, or an `Array` of `Object`,
+   * which defines aliases used to replace values in `import` or `require` statements.
+   * With either format, the order of the entries is important,
+   * in that the first defined rules are applied first.
+   */
+  entries?: readonly Alias[] | { [find: string]: string };
 }
 
 /**

diff --git a/packages/auto-install/tsconfig.json b/packages/auto-install/tsconfig.json
@@ -1,9 +1,5 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    "lib": ["es6"],
-    "module": "esnext"
-  },
   "include": [
     "src/**/*",
     "types/**/*"

diff --git a/packages/beep/package.json b/packages/beep/package.json
@@ -21,7 +21,7 @@
     "ci:test": "ava --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache lib test --ext .js,.ts",
+    "lint:js": "eslint --fix --cache lib test types --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "test": "ava"
   },

diff --git a/packages/beep/types/index.d.ts b/packages/beep/types/index.d.ts
@@ -1,6 +1,6 @@
-import { Plugin } from 'rollup';
-
-/**
- * 🍣 A Rollup plugin that beeps when a build ends with errors.
- */
-export default function beep(): Plugin;
+import { Plugin } from 'rollup';
+
+/**
+ * 🍣 A Rollup plugin that beeps when a build ends with errors.
+ */
+export default function beep(): Plugin;
diff --git a/packages/buble/tsconfig.json b/packages/buble/tsconfig.json
@@ -1,13 +1,7 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    "lib": ["es6"],
-    "module": "esnext",
-    "allowJs": true
-  },
   "include": [
     "src/**/*",
-    "types/**/*",
-    "typings-test.js"
+    "types/**/*"
   ]
 }
diff --git a/packages/dsv/package.json b/packages/dsv/package.json
@@ -19,7 +19,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/html/package.json b/packages/html/package.json
@@ -21,7 +21,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write *.md",
-    "lint:js": "eslint --fix --cache lib test",
+    "lint:js": "eslint --fix --cache lib test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prepublishOnly": "pnpm run lint",
     "test": "ava"

diff --git a/packages/image/package.json b/packages/image/package.json
@@ -22,7 +22,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write *.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/inject/package.json b/packages/inject/package.json
@@ -19,7 +19,7 @@
     "ci:test": "pnpm run test -- --verbose && pnpm run test:ts",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/json/package.json b/packages/json/package.json
@@ -17,9 +17,10 @@
     "ci:lint": "pnpm run build && pnpm run lint",
     "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
     "ci:test": "pnpm run test -- --verbose && pnpm run test:ts",
-    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
+    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:json && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
     "lint:js": "eslint --fix --cache src test types --ext .js,.ts",
+    "lint:json": "prettier --write \"test/fixtures/!(garbage)/*.json\"",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/json/test/fixtures/array/config.json b/packages/json/test/fixtures/array/config.json
@@ -1,3 +1 @@
-[
-  1, 2, 3
-]
+[1, 2, 3]
diff --git a/packages/json/test/fixtures/basic/config.json b/packages/json/test/fixtures/basic/config.json
@@ -1,3 +1,3 @@
 {
-	"answer": 42
+  "answer": 42
 }
diff --git a/packages/json/test/fixtures/extensionless/config.json b/packages/json/test/fixtures/extensionless/config.json
@@ -1,3 +1,3 @@
 {
-	"answer": 42
+  "answer": 42
 }
diff --git a/packages/json/test/fixtures/extensionless/dir/index.json b/packages/json/test/fixtures/extensionless/dir/index.json
@@ -1,3 +1,3 @@
 {
-	"Are extensionless imports and /index resolutions a good idea?": "No."
+  "Are extensionless imports and /index resolutions a good idea?": "No."
 }
diff --git a/packages/json/test/fixtures/named/package.json b/packages/json/test/fixtures/named/package.json
@@ -1,4 +1,4 @@
 {
-	"name": "this-should-be-excluded",
-	"version": "1.33.7"
+  "name": "this-should-be-excluded",
+  "version": "1.33.7"
 }
diff --git a/packages/legacy/package.json b/packages/legacy/package.json
@@ -19,7 +19,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/multi-entry/package.json b/packages/multi-entry/package.json
@@ -19,7 +19,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/pluginutils/package.json b/packages/pluginutils/package.json
@@ -24,7 +24,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src --ext .js,.ts",
+    "lint:js": "eslint --fix --cache src test types --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/pluginutils/tsconfig.json b/packages/pluginutils/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "lib": ["es6"],
     "esModuleInterop": true
   },
   "include": [

diff --git a/packages/strip/package.json b/packages/strip/package.json
@@ -19,7 +19,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test/test.js",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "pretest": "pnpm run build",
     "test": "ava"

diff --git a/packages/sucrase/package.json b/packages/sucrase/package.json
@@ -22,7 +22,7 @@
     "ci:test": "pnpm run test -- --verbose",
     "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test",
+    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/typescript/package.json b/packages/typescript/package.json
@@ -20,9 +20,10 @@
     "ci:lint": "pnpm run build && pnpm run lint",
     "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
     "ci:test": "pnpm run test -- --verbose --serial",
-    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
+    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:json && pnpm run lint:package",
     "lint:docs": "prettier --single-quote --write README.md",
-    "lint:js": "eslint --fix --cache src test --ext .js,.ts",
+    "lint:js": "eslint --fix --cache src test types --ext .js,.ts",
+    "lint:json": "prettier --write **/tsconfig.json",
     "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",

diff --git a/packages/typescript/test/fixtures/project-references/animals/tsconfig.json b/packages/typescript/test/fixtures/project-references/animals/tsconfig.json
@@ -1,10 +1,8 @@
-{
-  "extends": "../tsconfig-base.json",
-  "compilerOptions": {
-    "outDir": "../lib/animals",
-    "rootDir": ".",
-  },
-  "references": [
-    { "path": "../core" }
-  ]
-}
+{
+  "extends": "../tsconfig-base.json",
+  "compilerOptions": {
+    "outDir": "../lib/animals",
+    "rootDir": "."
+  },
+  "references": [{ "path": "../core" }]
+}
diff --git a/packages/typescript/test/fixtures/project-references/core/tsconfig.json b/packages/typescript/test/fixtures/project-references/core/tsconfig.json
@@ -1,7 +1,7 @@
-{
-  "extends": "../tsconfig-base.json",
-  "compilerOptions": {
-    "outDir": "../lib/core",
-    "rootDir": "."
-  }
-}
+{
+  "extends": "../tsconfig-base.json",
+  "compilerOptions": {
+    "outDir": "../lib/core",
+    "rootDir": "."
+  }
+}
diff --git a/packages/typescript/test/fixtures/project-references/tsconfig.json b/packages/typescript/test/fixtures/project-references/tsconfig.json
@@ -1,14 +1,14 @@
-{
-  "files": [],
-  "references": [
-    {
-      "path": "./core"
-    },
-    {
-      "path": "./animals"
-    },
-    {
-      "path": "./zoo"
-    }
-  ]
-}
+{
+  "files": [],
+  "references": [
+    {
+      "path": "./core"
+    },
+    {
+      "path": "./animals"
+    },
+    {
+      "path": "./zoo"
+    }
+  ]
+}
diff --git a/packages/typescript/test/fixtures/project-references/zoo/tsconfig.json b/packages/typescript/test/fixtures/project-references/zoo/tsconfig.json
@@ -1,12 +1,12 @@
-{
-  "extends": "../tsconfig-base.json",
-  "compilerOptions": {
-    "outDir": "../lib/zoo",
-    "rootDir": "."
-  },
-  "references": [
-    {
-      "path": "../animals"
-    }
-  ]
-}
+{
+  "extends": "../tsconfig-base.json",
+  "compilerOptions": {
+    "outDir": "../lib/zoo",
+    "rootDir": "."
+  },
+  "references": [
+    {
+      "path": "../animals"
+    }
+  ]
+}
diff --git a/packages/typescript/test/fixtures/tsconfig-extends-module/tsconfig.json b/packages/typescript/test/fixtures/tsconfig-extends-module/tsconfig.json
@@ -1,6 +1,6 @@
-{
-  "extends": "shared-config",
-  "compilerOptions": {
-    "allowJs": true
-  }
-}
+{
+  "extends": "shared-config",
+  "compilerOptions": {
+    "allowJs": true
+  }
+}
diff --git a/packages/typescript/tsconfig.json b/packages/typescript/tsconfig.json
@@ -1,13 +1,4 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    "lib": ["es6"],
-    "module": "esnext",
-    "allowJs": true
-  },
-  "include": [
-    "src/**/*",
-    "types/**/*",
-    "typings-test.js"
-  ]
+  "include": ["src/**/*", "types/**/*"]
 }