Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds configurable batching support #10

Merged

Conversation

Soundarya03
Copy link
Contributor

changes enabling batching settings in publisher config element

changes enabling batching settings in publisher config element
@Soundarya03
Copy link
Contributor Author

#9 addresses this issue

@Soundarya03
Copy link
Contributor Author

Soundarya03 commented Jan 2, 2025

Hi @rollno748 , any feedback on this?

@rollno748
Copy link
Owner

Hi @Soundarya03,

Apologies for the delay. It's been quite a long time working on this repo.
I see the current changes wont impact the existing functionalities
May i ask you, can you bump the plugin version and gcp pubsub lib and its dependent version to latest - so that, it will be easy for me to merge it to master and publish it to plugins manager

Thanks

updates gcp pubsub to 1.132.4

updates gson to 2.11.0
@Soundarya03
Copy link
Contributor Author

Soundarya03 commented Jan 3, 2025

Hi @rollno748 , I've made the changes. The google-cloud-pubsub dep I've updated to 1.132.4, and not the latest (1.135.0), because of an opentelemetry dependency it brings in starting 1.133. I thought that might be a change for later, as it might require some more analysis. https://github.com/googleapis/java-pubsub/blob/main/CHANGELOG.md

Hope this is fine for now

Copy link
Owner

@rollno748 rollno748 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rollno748 rollno748 merged commit ea2f6a5 into rollno748:master Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants