-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mention --rollkit.da_block_time as a tip in celestia and avail tuts #404
Conversation
WalkthroughThe changes introduce an option to set the Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
tutorials/celestia-da.md (1)
Line range hint
117-118
: Potential security risk: exposed JSON Web Token.Exposing JSON Web Tokens in documentation can lead to security risks. Consider removing or obfuscating the token.
- Your DA AUTH_TOKEN is eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJBbGxvdyI6WyJwdWJsaWMiLCJyZWFkIiwid3JpdGUiXX0.cSrJjpfUdTNFtzGho69V0D_8kyECn9Mzv8ghJSpKRDE + Your DA AUTH_TOKEN is <token>
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tutorials/avail-da.md (1 hunks)
- tutorials/celestia-da.md (1 hunks)
Additional context used
LanguageTool
tutorials/avail-da.md
[uncategorized] ~29-~29: You might be missing the article “the” here.
Context: ... just an Avail light node is enough for Turing testnet. Run the Avail light node using...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Markdownlint
tutorials/celestia-da.md
60-60: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
63-63: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
72-72: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Gitleaks
tutorials/celestia-da.md
117-118: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
(jwt)
Additional comments not posted (5)
tutorials/avail-da.md (2)
73-75
: Documentation addition is clear and informative.The explanation about the
--rollkit.da_block_time
flag is clear and helps users understand its purpose and default setting. This addition aligns well with the tutorial's objective to guide users in configuring their rollup on Avail's DA network.
Line range hint
29-29
: Consider adding the definite article for clarity.The sentence could be improved by adding "the" before "Turing testnet" to enhance readability and flow.
- Running just an Avail light node is enough for Turing testnet. + Running just an Avail light node is enough for the Turing testnet.tutorials/celestia-da.md (3)
86-88
: Documentation addition is clear and informative.The explanation about the
--rollkit.da_block_time
flag is clear and helps users understand its purpose and default setting. This addition aligns well with the tutorial's objective to guide users in configuring their rollup on Celestia's DA network.
Line range hint
60-60
: Remove unnecessary blank lines.Multiple consecutive blank lines should be avoided to maintain clean and concise documentation formatting.
- -Also applies to: 63-63
Line range hint
72-72
: Specify language for code blocks.It's best practice to specify the language for code blocks to enable syntax highlighting and improve readability.
- ``` + ```bash
Summary by CodeRabbit
New Features
--rollkit.da_block_time
flag to specify the finality time of the DA layer, with a default value of 15 seconds.Documentation
avail-da.md
andcelestia-da.md
tutorials to include guidance on the--rollkit.da_block_time
flag.