Minor updates to Wordle #373
Conversation
* Add celestia-da tutorial, network agnostic * Update vitepress config * Add link to /guides/gas-price * Update tutorials/celestia-da.md Co-authored-by: joshcs.eth <[email protected]> * Update tutorials/celestia-da.md Co-authored-by: joshcs.eth <[email protected]> * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update tutorials/celestia-da.md * Update tutorials/celestia-da.md * Update tutorials/celestia-da.md * Apply suggestions from code review * Apply suggestions from code review * Update tutorials/gm-world.md Co-authored-by: joshcs.eth <[email protected]> * Remove sudo, we install gmd, no need to use sudo now * docs: use 1 line for install instead of 2 --------- Co-authored-by: joshcs.eth <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
- Update links to Cosmos SDK docs - Remove Celestia DA from script and steps - Add "Next Steps" section pointing to Celestia DA
|
Warning Rate Limit Exceeded@jcstein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 16 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on enhancing development tools and tutorials, with significant changes in script functionalities and tutorial content. This includes the addition of new scripts for installation and setup, updates to existing tutorials, and the introduction of a new tutorial on deploying a GM world rollup on Celestia's network. Changes aim to streamline processes and update educational resources. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Out of diff range and nitpick comments (5)
tutorials/gm-world-frontend.md (1)
Line range hint
55-55: Remove consecutive blank lines to adhere to markdown best practices.- -tutorials/gm-world.md (1)
Line range hint
42-42: Remove consecutive blank lines to adhere to markdown best practices.- -tutorials/wordle.md (3)
Line range hint
156-156: Ensure table formatting is consistent with trailing pipes.- | File/directory | Purpose | + | File/directory | Purpose | |
285-285: Review the use of cryptographic functions for non-cryptographic purposes.Using SHA-256 for generating indices might be overkill and could be replaced with simpler hashing mechanisms if cryptographic properties are not required.
548-548: Ensure consistent error messages and consider user experience when displaying errors.Refining error messages to be more user-friendly can improve the user experience significantly. For example, instead of "Guess Must Only Consist of Alphabet Letters!", consider "Please ensure your guess contains only alphabet letters."
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- .vitepress/config.ts (1 hunks)
- .vitepress/constants/constants.js (1 hunks)
- public/install-gm-frontend-app.sh (1 hunks)
- public/install-go.sh (1 hunks)
- public/install-jq.sh (1 hunks)
- public/install-yarn.sh (1 hunks)
- public/wordle/init.sh (2 hunks)
- tutorials/celestia-da.md (1 hunks)
- tutorials/gm-world-frontend.md (1 hunks)
- tutorials/gm-world.md (3 hunks)
- tutorials/wordle.md (9 hunks)
Files skipped from review due to trivial changes (2)
- .vitepress/config.ts
- public/install-gm-frontend-app.sh
Additional Context Used
ShellCheck (18)
public/install-go.sh (4)
[info] 31-31: Double quote to prevent globbing and word splitting.
[info] 31-31: Double quote to prevent globbing and word splitting.
[info] 31-31: Double quote to prevent globbing and word splitting.
[warning] 114-114: ShellCheck can't follow non-constant source. Use a directive to specify location.
public/install-jq.sh (4)
[error] 3-3: Couldn't find 'fi' for this 'if'.
[error] 3-3: Couldn't parse this if expression. Fix to allow more checks.
[error] 40-40: Expected 'fi' matching previously mentioned 'if'.
[error] 40-40: Expected 'fi'. Fix any mentioned problems and try again.
public/install-yarn.sh (8)
[warning] 33-33: In POSIX sh, 'source' in place of '.' is undefined.
[warning] 33-33: ShellCheck can't follow non-constant source. Use a directive to specify location.
[info] 36-36: Double quote to prevent globbing and word splitting.
[info] 39-39: Double quote to prevent globbing and word splitting.
[info] 44-44: Double quote to prevent globbing and word splitting.
[info] 48-48: Double quote to prevent globbing and word splitting.
[info] 48-48: Double quote to prevent globbing and word splitting.
[info] 48-48: Double quote to prevent globbing and word splitting.
public/wordle/init.sh (2)
[warning] 7-7: CHAINFLAG appears unused. Verify use (or export if used externally).
[info] 36-36: Double quote to prevent globbing and word splitting.
Additional comments not posted (5)
.vitepress/constants/constants.js (1)
4-6: The addition ofnodeVersionandyarnVersionconstants is correctly implemented and follows best practices by usingObject.freeze.tutorials/gm-world-frontend.md (1)
3-3: Correctly updated the import statement to use constants from the.vitepress/constants/constants.jsfile.public/install-go.sh (1)
120-120: The update to dynamically determine the Go executable path using$(which go)is a good practice, enhancing the script's flexibility and compatibility.tutorials/celestia-da.md (1)
1-119: The new tutorial for deploying a GM world rollup on Celestia's network is comprehensive and well-structured, providing clear instructions and appropriate use of markdown.tutorials/gm-world.md (1)
2-2: The updated description aligns well with the new focus of the tutorial on using only Rollkit CLI and a mock DA network.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| Follow instructions to install and start your Celestia Data Availability | ||
| layer Light Node selecting the Arabica Devnet. You can | ||
| find instructions to install and run the node [here](https://docs.celestia.org/nodes/light-node). | ||
| ### 🪶 Run a mock DA node {#run-mock-da-node} |
There was a problem hiding this comment.
btw these {#headings} are for custom anchors, where for example, the emoji would make the linkable heading ugly. https://vitepress.dev/guide/markdown#custom-anchors
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tutorials/gm-world-frontend.md (1 hunks)
- tutorials/wordle.md (9 hunks)
Files not reviewed due to errors (1)
- tutorials/wordle.md (no review received)
Files skipped from review as they are similar to previous changes (1)
- tutorials/gm-world-frontend.md
Is based on the #372, so should go after
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Documentation