fix(da): account for blob tx proto overhead

[tuxcanfly]

Overview

This PR updates the max blob size to account for protobuf overhead due to blob tx encoding.

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

Summary by CodeRabbit

• Refactor
  • Adjusted the calculation for maximum default bytes to account for additional overhead, enhancing data handling efficiency.

[coderabbitai]

Walkthrough

This update brings a refined approach to calculating the DefaultMaxBytes in the Celestia application. By incorporating additional overhead into the computation, the new default maximum byte size is set at 1,842,714 bytes. This adjustment enhances the application's data handling capabilities, ensuring a more accurate and efficient processing environment.

Changes

File(s)	Summary
celestia/celestia.go	Adjusted DefaultMaxBytes calculation to include additional overhead, setting new value at 1,842,714 bytes.

🐇🌟
In the realm of code, where bytes do flow,
A rabbit hopped, with wisdom to bestow.
"Adjust the bytes," it whispered with glee,
"For in the numbers, truth you'll see."
Now with more room, the data dances free,
A change so small, yet vast as the sea. 🌊🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fcf1f7) 66.04% compared to head (3719f46) 66.04%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files           2        2           
  Lines         162      162           
=======================================
  Hits          107      107           
  Misses         43       43           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9fcf1f7 and 3719f46.

Files selected for processing (1)

• celestia/celestia.go (1 hunks)

Additional comments: 1

celestia/celestia.go (1)

• 24-27: The calculation for DefaultMaxBytes correctly accounts for the protobuf overhead by subtracting the specified amounts from the initial value. This change aligns with the PR objectives to accurately reflect the maximum blob size including encoding overhead. Ensure that this new limit is consistently applied wherever DefaultMaxBytes is used throughout the codebase to avoid inconsistencies.