795-fix: Fix slider button #797
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Lighthouse Report:
|
SpaNb4
reviewed
Feb 24, 2025
| @@ -118,18 +118,18 @@ figure { | |||
| .control-prev { | |||
| --slider-arrow-btn-height: 45px; | |||
|
|
|||
| top: calc(50% - var(--slider-arrow-btn-height) / 2); | |||
| top: calc(50% - var(--slider-arrow-btn-height) / 2) !important; | |||
There was a problem hiding this comment.
Can we avoid using !important and increase css specificity some other way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (select all that apply)
Description
Fix alignment of arrow controls of the "RS in pictures" carousel.
I had to use the !important marker because need to overwrite the external
react-responsive-carouselstyles.Related Tickets & Documents
Screenshots, Recordings
Before:
After:
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?