Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

792-fix: Windows npm run test #793

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

karlovich
Copy link
Collaborator

@karlovich karlovich commented Feb 12, 2025

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Fix backslashes on Windows machines by converting them to forward slashes.

Related Tickets & Documents

Screenshots, Recordings

npm run test

image

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

  • Bug Fixes
    • Improved file path formatting to ensure consistent asset handling across operating systems, enhancing reliability on Windows.

@karlovich karlovich marked this pull request as draft February 12, 2025 07:57
@github-actions github-actions bot changed the title Correct img path on windows machines 792-fix: Windows npm run test Feb 12, 2025
@karlovich karlovich self-assigned this Feb 12, 2025
Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

πŸ“ Walkthrough

Walkthrough

The pull request updates the stubNextAssetImport function in vitest.config.ts by modifying the way the imgSrc variable is constructed. The change replaces backslashes (\) with forward slashes (/) to ensure consistent file path formatting across different operating systems, particularly for Windows. No other configuration or public entity declarations have been altered.

Changes

File Change Summary
vitest.config.ts Adjusted imgSrc assignment in stubNextAssetImport to replace backslashes with forward slashes.

Sequence Diagram(s)

sequenceDiagram
    participant S as stubNextAssetImport
    participant T as Path Transformer
    S->>T: Send relative file path (with "\")
    T-->>S: Return file path with "/" for consistency
Loading
✨ Finishing Touches
  • πŸ“ Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
vitest.config.ts (1)

65-65: LGTM! Consider using path.sep for better platform independence.

The fix correctly handles Windows backslashes, addressing the PR objective.

Consider using path.sep for a more platform-independent solution:

-const imgSrc = relative(process.cwd(), id).split('\\').join('/');
+const imgSrc = relative(process.cwd(), id).split(path.sep).join('/');
πŸ“œ Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 78db4a9 and 4d68888.

πŸ“’ Files selected for processing (1)
  • vitest.config.ts (1 hunks)

Copy link

Lighthouse Report:

  • Performance: 98 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@SpaNb4 SpaNb4 marked this pull request as ready for review February 12, 2025 08:35
@karlovich karlovich merged commit ef3e620 into main Feb 12, 2025
5 checks passed
@karlovich karlovich deleted the fix/792-windows-npm-run-test branch February 12, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The npm run test command fails on Windows laptops.
4 participants