-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
792-fix: Windows npm run test #793
Conversation
π WalkthroughWalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant S as stubNextAssetImport
participant T as Path Transformer
S->>T: Send relative file path (with "\")
T-->>S: Return file path with "/" for consistency
β¨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
vitest.config.ts (1)
65-65
: LGTM! Consider using path.sep for better platform independence.The fix correctly handles Windows backslashes, addressing the PR objective.
Consider using
path.sep
for a more platform-independent solution:-const imgSrc = relative(process.cwd(), id).split('\\').join('/'); +const imgSrc = relative(process.cwd(), id).split(path.sep).join('/');
Lighthouse Report:
|
What type of PR is this? (select all that apply)
Description
Fix backslashes on Windows machines by converting them to forward slashes.
Related Tickets & Documents
Screenshots, Recordings
npm run test
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit