Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not apply cross-check score more than max score of a task #2540

Merged
merged 5 commits into from
Oct 16, 2024
Merged

fix: Do not apply cross-check score more than max score of a task #2540

merged 5 commits into from
Oct 16, 2024

Conversation

REW1L
Copy link
Contributor

@REW1L REW1L commented Oct 15, 2024 •
edited
Loading

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

#2541

💡 Background and solution

Describe the big picture of your changes here

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

valerydluski
valerydluski approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@valerydluski valerydluski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last two comments are my personal opinion, you can safely skip them

client/src/pages/course/student/cross-check-review.tsx Outdated Show resolved Hide resolved
client/src/pages/course/student/cross-check-review.tsx Outdated Show resolved Hide resolved
@valerydluski valerydluski changed the title chore: Do not apply cross-check score more than max score of a task fix: Do not apply cross-check score more than max score of a task Oct 16, 2024
apalchys
apalchys approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@apalchys apalchys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@apalchys apalchys merged commit 758a203 into rolling-scopes:master Oct 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valerydluski valerydluski valerydluski approved these changes

@apalchys apalchys apalchys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@REW1L @apalchys @valerydluski