feat:implement loading student summary using nestjs #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apalchys
reviewed
Apr 30, 2024
nestjs/src/courses/course-students/course-students.controller.ts
Outdated
Show resolved
Hide resolved
apalchys
reviewed
Apr 30, 2024
| const student = await this.courseStudentService.getStudentByGithubId(courseId, studentGithubId); | ||
|
|
||
| const [score, mentor] = await Promise.all([ | ||
| this.courseStudentService.getStudentScore(student?.id || 0), |
There was a problem hiding this comment.
student?. if no user throw an error. Don't need to hide it.
There was a problem hiding this comment.
e.g. do
if (student == null) {
throw new NotFound(...)
}
apalchys
reviewed
Apr 30, 2024
| @@ -0,0 +1,177 @@ | |||
| import { User } from '@entities/user'; | |||
| import { MentorBasic, StageInterviewFeedbackJson } from '@common/models'; | |||
There was a problem hiding this comment.
Please do not import from @common/
If you need a model, just copy to nest. We want to kill @common
There was a problem hiding this comment.
@valerydluski let's figure it out together
There was a problem hiding this comment.
@valerydluski thank you fo explanation
apalchys
reviewed
Apr 30, 2024
| readonly mentorRepository: Repository<Mentor>, | ||
| ) {} | ||
|
|
||
| studentQuery() { |
There was a problem hiding this comment.
you don't need it. Please just use studentRepository where needed.
apalchys
reviewed
Apr 30, 2024
Comment on lines
31
to
35
| const record = await this.studentQuery() | ||
| .innerJoin('student.user', 'user') | ||
| .where('user.githubId = :githubId', { githubId }) | ||
| .andWhere('student.courseId = :courseId', { courseId }) | ||
| .getOne(); |
There was a problem hiding this comment.
let's rewrite it and do like:
this.studentRepository.findOne({
where: {
courseId,
user: { githubId },
},
relations: ['user']
})
apalchys
reviewed
Apr 30, 2024
client/src/services/course.ts
Outdated
| const result = await this.axios.get(`/student/${githubId}/summary`); | ||
| return result.data.data as StudentSummary; | ||
| const result = await studentsApi.getStudentSummary(this.courseId, githubId); | ||
| return result.data as unknown as StudentSummary; |
There was a problem hiding this comment.
just curious, why do you need cast to unknown ? what's wrong with types?
| @@ -304,7 +304,7 @@ export class CourseScheduleService { | |||
| ...(technicalScreeningResults | |||
| .find(task => task.courseTaskId === courseTaskId) | |||
| ?.stageInterviewFeedbacks.map(feedback => JSON.parse(feedback.json)) | |||
| .map((json: any) => json?.resume?.score ?? 0) ?? []), | |||
| .map((json: any) => (json?.resume?.score || json?.steps?.decision?.values?.finalScore) ?? 0) ?? []), | |||
There was a problem hiding this comment.
Let's split it a bit and make more readable
Suggested change
| .map((json: any) => (json?.resume?.score || json?.steps?.decision?.values?.finalScore) ?? 0) ?? []), | |
| .map((json: any) => { | |
| const resumeScore = json?.resume?.score; | |
| const decisionScore = json?.steps?.decision?.values?.finalScore; | |
| return resumeScore ?? decisionScore ?? 0; | |
| }); |
| rank: score?.rank, | ||
| isActive: !student?.isExpelled && !student?.isFailed, | ||
| mentor, | ||
| repository: student?.repository || null, |
There was a problem hiding this comment.
Suggested change
| repository: student?.repository || null, | |
| repository: student?.repository ?? null, |
AlreadyBored
reviewed
Jun 6, 2024
Comment on lines
158
to
167
| const user = (mentor.user as User)!; | ||
| return { | ||
| isActive: !mentor.isExpelled, | ||
| name: createName(user), | ||
| id: mentor.id, | ||
| githubId: user.githubId, | ||
| students: mentor.students ? mentor.students.filter(s => !s.isExpelled && !s.isFailed).map(s => ({ id: s.id })) : [], | ||
| cityName: user.cityName ?? '', | ||
| countryName: user.countryName ?? '', | ||
| }; |
There was a problem hiding this comment.
Type of mentor.user is User without this typecast
Suggested change
| const user = (mentor.user as User)!; | |
| return { | |
| isActive: !mentor.isExpelled, | |
| name: createName(user), | |
| id: mentor.id, | |
| githubId: user.githubId, | |
| students: mentor.students ? mentor.students.filter(s => !s.isExpelled && !s.isFailed).map(s => ({ id: s.id })) : [], | |
| cityName: user.cityName ?? '', | |
| countryName: user.countryName ?? '', | |
| }; | |
| return { | |
| isActive: !mentor.isExpelled, | |
| name: createName(mentor.user), | |
| id: mentor.id, | |
| githubId: user.githubId, | |
| students: mentor.students ? mentor.students.filter(s => !s.isExpelled && !s.isFailed).map(s => ({ id: s.id })) : [], | |
| cityName: user.cityName ?? '', | |
| countryName: user.countryName ?? '', | |
| }; |
AlreadyBored
reviewed
Jun 6, 2024
Comment on lines
1
to
58
| interface StageInterviewFeedback { | ||
| common: { | ||
| reason: 'haveITEducation' | 'doNotWorkInIT' | 'whatThisCourseAbout' | 'other' | null; | ||
| reasonOther: string | null; | ||
| whenStartCoding: number | null; | ||
| schoolChallengesParticipaton: string | null; | ||
| whereStudied: string | null; | ||
| workExperience: string | null; | ||
| otherAchievements: string | null; | ||
| militaryService: 'served' | 'liable' | 'notLiable' | null; | ||
| }; | ||
| skills?: { | ||
| [index: string]: any; | ||
| htmlCss: { | ||
| level: number | null; | ||
| }; | ||
| dataStructures: { | ||
| array: number | null; | ||
| list: number | null; | ||
| stack: number | null; | ||
| queue: number | null; | ||
| tree: number | null; | ||
| hashTable: number | null; | ||
| heap: number | null; | ||
| }; | ||
| common: { | ||
| binaryNumber: number | null; | ||
| oop: number | null; | ||
| bigONotation: number | null; | ||
| sortingAndSearchAlgorithms: number | null; | ||
| }; | ||
| comment: string | null; | ||
| }; | ||
| programmingTask: { | ||
| task: string | null; | ||
| codeWritingLevel: number | null; | ||
| resolved: number | null; | ||
| comment: string | null; | ||
| }; | ||
| resume: { | ||
| verdict: StageInterviewFeedbackVerdict; | ||
| comment: string | null; | ||
| score: number; | ||
| }; | ||
| } | ||
|
|
||
| export type StageInterviewFeedbackVerdict = 'yes' | 'no' | 'noButGoodCandidate' | 'didNotDecideYet' | null; | ||
|
|
||
| export type EnglishLevel = 'a0' | 'a1' | 'a1+' | 'a2' | 'a2+' | 'b1' | 'b1+' | 'b2' | 'b2+' | 'c1' | 'c1+' | 'c2'; | ||
|
|
||
| export interface StageInterviewFeedbackJson extends StageInterviewFeedback { | ||
| english: { | ||
| levelStudentOpinion: EnglishLevel | null; | ||
| levelMentorOpinion: EnglishLevel | null; | ||
| whereAndWhenLearned: string | null; | ||
| comment: string | null; | ||
| }; | ||
| } |
There was a problem hiding this comment.
We have all these models in common/models, why do you duplicate it here?
apalchys
approved these changes
Jul 9, 2024
📦 Next.js Bundle Analysis for clientThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Fifty-eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 Add
deploylabel if you want to deploy this Pull Request to staging environment🧑⚖️ Pull Request Naming Convention
area:*label(s)🤔 This is a ...
🔗 Related issue link
Describe the source of requirement, like related issue link.
💡 Background and solution
Describe the big picture of your changes here
☑️ Self Check before Merge