Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show student score in first position #2314

Merged
merged 11 commits into from
Nov 29, 2023
Merged

feat: show student score in first position #2314

merged 11 commits into from
Nov 29, 2023

Conversation

NikitaKorevo
Copy link
Contributor

@NikitaKorevo NikitaKorevo commented Oct 5, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

#2285

πŸ’‘ Background and solution

After:

chrome_kDr7shXlEh.mp4
Deprecated
chrome_WMYGKkCpBu.mp4

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 165.59 KB (🟑 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 289.59 KB 455.19 KB 91.04% (🟑 +0.01%)
/404 225.68 KB 391.27 KB 78.25% (🟑 +0.01%)
/admin/courses 377.62 KB 543.21 KB 108.64% (🟑 +0.01%)
/admin/disciplines 323.62 KB 489.21 KB 97.84% (🟑 +0.01%)
/admin/discord-server 350.42 KB 516.01 KB 103.20% (🟑 +0.01%)
/admin/events 351 KB 516.59 KB 103.32% (🟑 +0.01%)
/admin/mentor-registry 374.33 KB 539.92 KB 107.98% (🟑 +0.02%)
/admin/notifications 389.87 KB 555.46 KB 111.09% (🟑 +0.01%)
/admin/prompts 331.39 KB 496.98 KB 99.40% (🟑 +0.01%)
/admin/registrations 326.35 KB 491.94 KB 98.39% (🟑 +0.01%)
/admin/tasks 431.71 KB 597.3 KB 119.46% (🟑 +0.01%)
/admin/user-group 374.85 KB 540.45 KB 108.09% (🟑 +0.01%)
/admin/users 271.99 KB 437.58 KB 87.52% (🟑 +0.01%)
/applicants 309.55 KB 475.14 KB 95.03% (🟑 +0.01%)
/course/admin/cross-check-table 427.63 KB 593.22 KB 118.64% (🟑 +0.02%)
/course/admin/events 431.43 KB 597.02 KB 119.40% (🟑 +0.02%)
/course/admin/interviews 373.88 KB 539.47 KB 107.89% (🟑 +0.02%)
/course/admin/mentors 378.48 KB 544.08 KB 108.82% (🟑 +0.01%)
/course/admin/stage-interviews 375.51 KB 541.1 KB 108.22% (🟑 +0.01%)
/course/admin/students 386.43 KB 552.02 KB 110.40% (🟑 +0.02%)
/course/admin/tasks 406.82 KB 572.41 KB 114.48% (🟑 +0.01%)
/course/admin/users 373.55 KB 539.14 KB 107.83% (🟑 +0.01%)
/course/interview/[type]/feedback 340.04 KB 505.63 KB 101.13% (🟑 +0.01%)
/course/mentor/auto-confirm 227.87 KB 393.46 KB 78.69% (🟑 +0.01%)
/course/mentor/confirm 291.63 KB 457.22 KB 91.44% (🟑 +0.02%)
/course/mentor/dashboard 395.4 KB 561 KB 112.20% (🟑 +0.01%)
/course/mentor/expel-student 295.64 KB 461.23 KB 92.25% (🟑 +0.01%)
/course/mentor/feedback 297.74 KB 463.33 KB 92.67% (🟑 +0.01%)
/course/mentor/interview-technical-screening 265.41 KB 431 KB 86.20% (🟑 +0.01%)
/course/mentor/interview-wait-list 333.89 KB 499.48 KB 99.90% (🟑 +0.01%)
/course/mentor/interviews 345.33 KB 510.92 KB 102.18% (🟑 +0.02%)
/course/mentor/students 250.45 KB 416.04 KB 83.21% (🟑 +0.01%)
/course/schedule 471.81 KB 637.4 KB 127.48% (🟑 +0.01%)
/course/score 333.57 KB 499.16 KB 99.83% (🟑 +0.05%)
/course/student/auto-test 384.12 KB 549.71 KB 109.94% (🟑 +0.01%)
/course/student/auto-test/task 384.03 KB 549.63 KB 109.93% (🟑 +0.01%)
/course/student/cross-check-review 411.4 KB 576.99 KB 115.40% (🟑 +0.01%)
/course/student/cross-check-submit 426.87 KB 592.46 KB 118.49% (🟑 +0.01%)
/course/student/dashboard 391.23 KB 556.83 KB 111.37% (🟑 +0.01%)
/course/student/interviews 300.37 KB 465.96 KB 93.19% (🟑 +0.01%)
/course/submit-scores 406.39 KB 571.98 KB 114.40% (🟑 +0.01%)
/course/team-distributions 377.48 KB 543.07 KB 108.61% (🟑 +0.02%)
/course/teams 419.58 KB 585.17 KB 117.03% (🟑 +0.02%)
/cv/[uuid] 241.33 KB 406.92 KB 81.38% (🟑 +0.01%)
/cv/edit 344.22 KB 509.81 KB 101.96% (🟑 +0.01%)
/gratitude 290.23 KB 455.82 KB 91.16% (🟑 +0.01%)
/heroes 392.11 KB 557.7 KB 111.54% (🟑 +0.05%)
/job 170.75 KB 336.34 KB 67.27% (🟑 +0.01%)
/profile 398.61 KB 564.2 KB 112.84% (🟑 +0.01%)
/profile/connection-confirmed 266.21 KB 431.8 KB 86.36% (🟑 +0.01%)
/profile/notifications 326.56 KB 492.15 KB 98.43% (🟑 +0.01%)
/registry/epamlearningjs 289.89 KB 455.49 KB 91.10% (🟑 +0.01%)
/registry/mentor 340.07 KB 505.67 KB 101.13% (🟑 +0.01%)
/registry/student 340.07 KB 505.67 KB 101.13% (🟑 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@NikitaKorevo NikitaKorevo marked this pull request as draft October 5, 2023 18:54
@NikitaKorevo NikitaKorevo force-pushed the issue/2285 branch 3 times, most recently from f6ab20a to af49512 Compare October 18, 2023 20:06
@NikitaKorevo NikitaKorevo marked this pull request as ready for review October 18, 2023 20:27
@dzmitry-varabei dzmitry-varabei merged commit f6ae53e into master Nov 29, 2023
6 checks passed
@dzmitry-varabei dzmitry-varabei deleted the issue/2285 branch November 29, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants