-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OutputAsset #231
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
pub mod asset; | ||
#[allow(clippy::module_inception)] | ||
pub mod bundle; | ||
pub mod output; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#[derive(Debug)] | ||
pub struct OutputChunk { | ||
pub file_name: String, | ||
pub code: String, | ||
pub is_entry: bool, | ||
pub facade_module_id: Option<String>, | ||
} | ||
|
||
#[derive(Debug)] | ||
pub struct OutputAsset { | ||
pub file_name: String, | ||
pub source: String, | ||
} | ||
|
||
#[derive(Debug)] | ||
pub enum Output { | ||
Chunk(Box<OutputChunk>), | ||
Asset(Box<OutputAsset>), | ||
} | ||
|
||
impl Output { | ||
pub fn file_name(&self) -> &str { | ||
match self { | ||
Self::Chunk(chunk) => &chunk.file_name, | ||
Self::Asset(asset) => &asset.file_name, | ||
} | ||
} | ||
|
||
pub fn content(&self) -> &str { | ||
match self { | ||
Self::Chunk(chunk) => &chunk.code, | ||
Self::Asset(asset) => &asset.source, | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
use derivative::Derivative; | ||
use serde::Deserialize; | ||
|
||
#[napi_derive::napi(object)] | ||
#[derive(Deserialize, Default, Derivative)] | ||
#[serde(rename_all = "camelCase")] | ||
#[derivative(Debug)] | ||
pub struct OutputChunk { | ||
pub code: String, | ||
pub file_name: String, | ||
pub is_entry: bool, | ||
pub facade_module_id: Option<String>, | ||
} | ||
|
||
impl From<Box<rolldown::OutputChunk>> for OutputChunk { | ||
fn from(chunk: Box<rolldown::OutputChunk>) -> Self { | ||
Self { | ||
code: chunk.code, | ||
file_name: chunk.file_name, | ||
is_entry: chunk.is_entry, | ||
facade_module_id: chunk.facade_module_id, | ||
} | ||
} | ||
} | ||
|
||
#[napi_derive::napi(object)] | ||
#[derive(Deserialize, Default, Derivative)] | ||
#[serde(rename_all = "camelCase")] | ||
#[derivative(Debug)] | ||
pub struct OutputAsset { | ||
pub file_name: String, | ||
pub source: String, | ||
} | ||
|
||
impl From<Box<rolldown::OutputAsset>> for OutputAsset { | ||
fn from(chunk: Box<rolldown::OutputAsset>) -> Self { | ||
Self { source: chunk.source, file_name: chunk.file_name } | ||
} | ||
} | ||
|
||
#[napi_derive::napi(object)] | ||
#[derive(Deserialize, Default, Derivative)] | ||
#[serde(rename_all = "camelCase")] | ||
#[derivative(Debug)] | ||
pub struct Outputs { | ||
pub chunks: Vec<OutputChunk>, | ||
pub assets: Vec<OutputAsset>, | ||
} | ||
|
||
impl From<Vec<rolldown::Output>> for Outputs { | ||
fn from(outputs: Vec<rolldown::Output>) -> Self { | ||
let mut chunks: Vec<OutputChunk> = vec![]; | ||
let mut assets: Vec<OutputAsset> = vec![]; | ||
|
||
outputs.into_iter().for_each(|o| match o { | ||
rolldown::Output::Chunk(chunk) => chunks.push(chunk.into()), | ||
rolldown::Output::Asset(asset) => assets.push(asset.into()), | ||
}); | ||
|
||
Self { chunks, assets } | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ export type { | |
OutputPlugin, | ||
OutputChunk, | ||
NormalizedInputOptions, | ||
OutputAsset, | ||
} from 'rollup' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here serializing enum to node is difficult. It also can be implemented by serialize to a reference and get actualy value by the reference. But the performance is slow than once serializing, so here I merge data to other structures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But serializing once maybe is bad for performance if here have a larger data at future, we can adjust it if we have larger data at future.