Unhandled rejections [Fixes #307] #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h this duplicates information that is already in message
|
It is non-standard but it's best to include more information than less especially when JS is so fre-form that you can throw non-exceptions/errors. |
|
Tagging issue #307 |
|
Much appreciated! |
|
Can we publish this to npm? |
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Unhandled rejections [Fixes #307]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rejecting with a non-error reason results in
reason.messageorString(reason)being set as the message to log. This gets rids of structure that the reason object might have had, so include the reason again to be picked up in custom data. I am not sure I would call it an anti-pattern per se to use non-errors as reasons for rejecting promises, but it is highly non-standard.