Merge pull request #311 from rollbar/verbosity

add back verbose logging
rollbar · Jun 15, 2017 · 07cac7a · 07cac7a
2 parents 616642f + 6eed11a
commit 07cac7a
Show file tree

Hide file tree

Showing 5 changed files with 167 additions and 37 deletions.
diff --git a/sdks/rollbar.js/src/browser/rollbar.js b/sdks/rollbar.js/src/browser/rollbar.js
@@ -291,6 +291,7 @@ var defaultOptions = {
   reportLevel: __DEFAULT_REPORT_LEVEL__,
   uncaughtErrorLevel: __DEFAULT_UNCAUGHT_ERROR_LEVEL,
   endpoint: __DEFAULT_ENDPOINT__,
+  verbose: false,
   enabled: true
 };
 

diff --git a/sdks/rollbar.js/src/queue.js b/sdks/rollbar.js/src/queue.js
@@ -10,11 +10,13 @@ var _ = require('./utility');
  *    rateLimiter.shouldSend(item) -> bool
  * @param api - An object which conforms to the interface
  *    api.postItem(payload, function(err, response))
+ * @param logger - An object used to log verbose messages if desired
  * @param options - see Queue.prototype.configure
  */
-function Queue(rateLimiter, api, options) {
+function Queue(rateLimiter, api, logger, options) {
   this.rateLimiter = rateLimiter;
   this.api = api;
+  this.logger = logger;
   this.options = options;
   this.predicates = [];
   this.pendingRequests = [];
@@ -37,7 +39,7 @@ Queue.prototype.configure = function(options) {
 
 /*
  * addPredicate - adds a predicate to the end of the list of predicates for this queue
- * 
+ *
  * @param predicate - function(item, options) -> (bool|{err: Error})
  *  Returning true means that this predicate passes and the item is okay to go on the queue
  *  Returning false means do not add the item to the queue, but it is not an error
@@ -73,6 +75,7 @@ Queue.prototype.addItem = function(item, callback) {
     callback();
     return;
   }
+  this._maybeLog(item);
   this.pendingRequests.push(item);
   try {
     this._makeApiRequest(item, function(err, resp) {
@@ -212,4 +215,19 @@ Queue.prototype._dequeuePendingRequest = function(item) {
   }
 };
 
+Queue.prototype._maybeLog = function(item) {
+  if (this.logger && this.options.verbose) {
+    var message = _.get(item, 'data.body.trace.exception.message');
+    message = message || _.get(item, 'data.body.trace_chain.0.exception.message');
+    if (message) {
+      this.logger.error(message);
+      return;
+    }
+    message = _.get(item, 'data.body.message.body');
+    if (message) {
+      this.logger.log(message);
+    }
+  }
+};
+
 module.exports = Queue;
diff --git a/sdks/rollbar.js/src/rollbar.js b/sdks/rollbar.js/src/rollbar.js
@@ -13,7 +13,7 @@ var _ = require('./utility');
 function Rollbar(options, api, logger) {
   this.options = _.extend(true, {}, options);
   this.logger = logger;
-  this.queue = new Queue(Rollbar.rateLimiter, api, this.options);
+  this.queue = new Queue(Rollbar.rateLimiter, api, logger, this.options);
   this.notifier = new Notifier(this.queue, this.options);
 }
 

diff --git a/sdks/rollbar.js/src/server/rollbar.js b/sdks/rollbar.js/src/server/rollbar.js
@@ -484,6 +484,7 @@ Rollbar.defaultOptions = {
   scrubFields: packageJson.defaults.server.scrubFields,
   addRequestData: null,
   reportLevel: packageJson.defaults.reportLevel,
+  verbose: false,
   enabled: true
 };