-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send pre/post code context for exceptions and errors #76
send pre/post code context for exceptions and errors #76
Conversation
Hey @modethirteen You're the man! This all looks really great. If you don't mind writing a test we'd really appreciate it! I realize this involves refactoring the file reading a bit. Let me know if you need anything from us. We'd be happy to offer you any assistance you need. |
@Crisfole no problem, i'll have the update shortly |
@Crisfole updated and tests added |
@modethirteen Nice! Thanks for that. I'll inspect later today, and get this merged in ASAP. |
@Crisfole sounds great -- does a new tag get cut after that? it would be great it we were running the mainline releases. |
@Crisfole any chance this will get merged soon? |
@modethirteen @nocive I'd like to merge this soon. Tagging and releasing would need at least one extra set of eyes. |
@brianr Take a peek? This looks good to me and it's tested. |
Testing this locally right now and then I'll merge |
Took a bunch longer because I discovered we didn't actually show the pre/post code yet, but had to make sure. This is fanstastic. Thank so much @modethirteen |
Adds lines of code before and after the "code" line, as described in https://rollbar.com/docs/api/items_post/. We've been using this @MindTouch for a couple years with good results.
I didn't write a test as it uses file() to load source files into arrays. If you think a test is necessary I can create an abstraction for file() that is mockable.