Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the curl extension in composer.json #54

Merged
merged 1 commit into from
May 19, 2015
Merged

Require the curl extension in composer.json #54

merged 1 commit into from
May 19, 2015

Conversation

jenssegers
Copy link
Contributor

I would also add a minimum PHP requirement.

@coryvirok
Copy link
Contributor

Thanks for the PR @jenssegers. PHP isn't my primary language so can you help me understand the need and any potential downsides for this change?

Thanks!

@jenssegers
Copy link
Contributor Author

This will warn users that try to install rollbar when they do not have the curl extension installed. You can do the same thing with a minimum PHP requirement, that will inform them if their PHP version is outdated if you are using specific version features.

@jenssegers
Copy link
Contributor Author

I did the same PR on Sentry's client: getsentry/raven-php@6faf446

@coryvirok
Copy link
Contributor

Gotcha. Thanks for the info.

coryvirok added a commit that referenced this pull request May 19, 2015
Require the curl extension in composer.json
@coryvirok coryvirok merged commit 80bd394 into rollbar:master May 19, 2015
@brianr
Copy link
Member

brianr commented May 27, 2015

Thanks @jenssegers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants